Block Editor List

[Shazwazza]

WIP PR for the block editor so we can start the review process.

Test notes:

• Nested Content in all possible ways, since the storage mechanism of nested content, has been changed a bit.
• Nested Content with deploy, I(Niels) just want to be sure that we haven't broken something here.
  — Block List Editor, Every possible thing you can think about, it's new so haven't been tested before.
• Block List Editor inside Block List Editor.
• Other advanced editors inside Block List Editor.
• Block List Editor inside advanced editors.
• Make sure that the above combinations of property editor also transfer nicely with Deploy.

[warrenbuckley]

I have looked at the last set of changes you have done @nielslyngsoe in your commits and they all look good.

@Shazwazza I had a few minor things mentioned - let me know if you want to deal with them and if we now want to say this is done and merge this into v8/dev and then start making smaller granular PRs?

[stefankip]

Hi! Don't know if it's okay for me to report a bug already, but here it goes 😇
I have created the datatype for the block list editor and created the first available block.
When I click the square with the word Add inside to add another block, a JS error occurs:

TypeError: Cannot read property 'alias' of undefined
    at umbraco.controllers.js?cdv=123:16027

The error is thrown here: https://github.com/umbraco/Umbraco-CMS/blob/v8/feature/block-editor-list/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist/prevalue/blocklist.blockconfiguration.controller.js#L102

[warrenbuckley]

Hi! Don't know if it's okay for me to report a bug already, but here it goes 😇
I have created the datatype for the block list editor and created the first available block.
When I click the square with the word Add inside to add another block, a JS error occurs:

TypeError: Cannot read property 'alias' of undefined
    at umbraco.controllers.js?cdv=123:16027

The error is thrown here: https://github.com/umbraco/Umbraco-CMS/blob/v8/feature/block-editor-list/src/Umbraco.Web.UI.Client/src/views/propertyeditors/blocklist/prevalue/blocklist.blockconfiguration.controller.js#L102

@stefankip thanks for being an early tester in this chaos. @nielslyngsoe is looking into this now and will be in a new PR :)

[stefankip]

@warrenbuckley just checking out all the new block editors on the block (🤣) and noticed this.

[nielslyngsoe]

@stefankip thanks for finding this and feel free to report anything.
Fixed in this PR: #8358

[joepvtl]

Hi, I was playing around with the block editor and found a small issue. If you have a settings model added to a block, then add the block to the page. If you then click on the block settings and when the popup opens click on the content tab, then close the popup and click on the block settings again, you will see that it opens the popup with both tabs enabled.

And I can't add a thumbnail when the image extension is in caps (.PNG).