Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected attribute on uui-avatar example #53

Merged
merged 1 commit into from Nov 15, 2021

Conversation

leekelleher
Copy link
Member

Description

I'd noticed that the example of the <uui-avatar> component uses src instead of img-src.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Following an example of how to use the <uui-avatar> component, I noticed that the README's example uses the src attribute, but that didn't work, and saw on Storybook that the attribute is img-src instead.

Checklist

  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I'd spotted that `src` should ben `img-src`.
@julczka
Copy link
Contributor

julczka commented Nov 15, 2021

Thanks for fixing this!

@julczka julczka merged commit 17a7ba4 into umbraco:dev Nov 15, 2021
@leekelleher leekelleher deleted the docs/uui-avatar/img-src branch March 15, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants