Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8: Update all Application Starting and Application Started event examples to use Composer approach #1579

Closed
16 of 19 tasks
marcemarc opened this issue Feb 22, 2019 · 3 comments
Closed
16 of 19 tasks

Comments

@marcemarc
Copy link
Contributor

@marcemarc marcemarc commented Feb 22, 2019

Throughout the documentation when showing how to extend different parts of Umbraco, there is usually included a snippet to show how to wire up an event or register a collection etc via creating a class that implements ApplicationEventHandler, for V8 a different approach is used, creation a IUserComposer to create a composition to customise the functionality of Umbraco.

Therefore all these pages need their examples updated for V8 version to use the new approach:

A list of pages here:

Application Starting

  • Extending\Section-Trees\Searchable-Trees\index.md
  • Getting-Started\Setup\Server-Setup\Load-Balancing\flexible-advanced.md
  • Getting-Started\Setup\Server-Setup\Load-Balancing\flexible.md
  • Implementation\Default-Routing\Controller-Selection\index.md
  • Reference\using-ioc.md
  • Reference\Events\Application-Startup.md
  • Reference\Events\Understanding-Bootmanagers.md
  • Reference\Routing\custom-controllers.md
  • Reference\Routing\Request-Pipeline\IContentFinder.md
  • Reference\Routing\Request-Pipeline\outbound-pipeline.md
  • Reference\Templating\Modelsbuilder\IPublishedContentModelFactory.md

Application Started

  • Getting-Started\Code\Subscribing-To-Events\index.md
  • Getting-Started\Code\Umbraco-Services\index.md
  • Reference\Events\ContentService-Events.md
  • Reference\Events\Extending-UmbracoApplication.md
  • Reference\Events\MediaService-Events.md
  • Reference\Events\EditorModel-Events\index.md
  • Reference\Routing\custom-routes.md
  • Reference\Routing\Authorized\index.md

Some of these will be quick wins, eg just updated the example to use the IUserComposer approach will make the documentation V8 ready... whereas on other pages, it will cause confusion, seeing the V8 method for wiring things up will imply the whole page of documentation applies to V8 when it might not

@nul800sebastiaan
Copy link
Member

@nul800sebastiaan nul800sebastiaan commented Mar 14, 2019

Hi @marcemarc - just to let you know, I've added the "idea" label on this since it will be a longer-term project and it's great that you keep working on it, but it doesn't need to be in the overview for HQ for open issue that require immediate attention.

Keep up the great work!

@marcemarc
Copy link
Contributor Author

@marcemarc marcemarc commented Mar 23, 2019

Raised issue for /routing/Authorized/index.md page as it doesn't work in V8 - umbraco/Umbraco-CMS#5005

@sofietoft
Copy link
Contributor

@sofietoft sofietoft commented Sep 18, 2020

Closing this, as the remaining items on the list are added here: #2292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants