Made a start on a sitemap tutorial#1242
Conversation
jmayntzhusen
left a comment
There was a problem hiding this comment.
Great job Marc, I will see if I can find some time to follow this guide today - do you want me to take some pictures of the steps? Then I can make a PR to your branch 🙂
|
@jmayntzhusen that would be ace, basically next step was to follow the tutorial (make sure it works) and add screenshots as it goes along, to illustrate what is meant, if someone other than me does that, then should spot things that aren't explained well or don't work etc...! |
Typo on containing Co-Authored-By: marcemarc <marc@snowmoon.co.uk>
|
I made everything work, have added some pictures and changed the small errors in the code to make it work, you can have a look at my changes now if you wish 😁 |
Testing end to end, updating screenshots, and wordings, explaining Razor Helpers and Functions
|
@jmayntzhusen back over to you... have gone through the tutorial, again and tweaked loads of things, but it is much more 'ready' to go now that the first attempt. |
(cherry picked from commit 277eab9d86c1b206f8c3d98e20cfd68b1e194616)
dampee
left a comment
There was a problem hiding this comment.
I think we should merge this
|
I agree with Damiaan, it seems finished at this point 🙂 |
With regard to this issue: #1222
Essentially most people would use one of sitemap plugins, it's whether this tutorial can be an introduction to writing code in views, and working with the structure of Umbraco to be worthwhile... there's plenty of ways you can build a sitemap, and this isn't necessarily the best... so bit wary of having it like this, or perhaps we have a go further that shows hijacking of the route etc
Anyway needs polish and some screenshots, that I'll have a look at in the next few weeks, so not quite ready to review yet...