Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a start on a sitemap tutorial #1242

Merged
merged 8 commits into from Dec 7, 2018

Conversation

@marcemarc
Copy link
Contributor

@marcemarc marcemarc commented Nov 11, 2018

With regard to this issue: #1222

Essentially most people would use one of sitemap plugins, it's whether this tutorial can be an introduction to writing code in views, and working with the structure of Umbraco to be worthwhile... there's plenty of ways you can build a sitemap, and this isn't necessarily the best... so bit wary of having it like this, or perhaps we have a go further that shows hijacking of the route etc

Anyway needs polish and some screenshots, that I'll have a look at in the next few weeks, so not quite ready to review yet...

Copy link
Contributor

@jmayntzhusen jmayntzhusen left a comment

Great job Marc, I will see if I can find some time to follow this guide today - do you want me to take some pictures of the steps? Then I can make a PR to your branch 🙂

Tutorials/Creating-an-XML-Site-Map/index.md Outdated Show resolved Hide resolved
Tutorials/Creating-an-XML-Site-Map/index.md Outdated Show resolved Hide resolved
Tutorials/Creating-an-XML-Site-Map/index.md Show resolved Hide resolved
@marcemarc
Copy link
Contributor Author

@marcemarc marcemarc commented Nov 13, 2018

@jmayntzhusen that would be ace, basically next step was to follow the tutorial (make sure it works) and add screenshots as it goes along, to illustrate what is meant, if someone other than me does that, then should spot things that aren't explained well or don't work etc...!

jmayntzhusen and others added 2 commits Nov 13, 2018
Typo on containing

Co-Authored-By: marcemarc <marc@snowmoon.co.uk>
@jmayntzhusen
Copy link
Contributor

@jmayntzhusen jmayntzhusen commented Nov 23, 2018

I made everything work, have added some pictures and changed the small errors in the code to make it work, you can have a look at my changes now if you wish 😁

Testing end to end, updating screenshots, and wordings, explaining Razor Helpers and Functions
@marcemarc
Copy link
Contributor Author

@marcemarc marcemarc commented Dec 2, 2018

@jmayntzhusen back over to you... have gone through the tutorial, again and tweaked loads of things, but it is much more 'ready' to go now that the first attempt.

dampee and others added 2 commits Dec 5, 2018
(cherry picked from commit 277eab9d86c1b206f8c3d98e20cfd68b1e194616)
dampee
dampee approved these changes Dec 5, 2018
Copy link
Contributor

@dampee dampee left a comment

I think we should merge this

@jmayntzhusen
Copy link
Contributor

@jmayntzhusen jmayntzhusen commented Dec 6, 2018

I agree with Damiaan, it seems finished at this point 🙂

@marcemarc marcemarc merged commit 494e34c into umbraco:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants