update xpath replacement for v14 #6027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonat123
reviewed
Apr 15, 2024
jonat123
reviewed
Apr 15, 2024
jonat123
reviewed
Apr 15, 2024
jonat123
reviewed
Apr 15, 2024
jonat123
requested changes
Apr 15, 2024
Contributor
jonat123
left a comment
jonat123
left a comment
There was a problem hiding this comment.
@alina-tincas Great PR! 😄
I have added a few suggestions 😊
Co-authored-by: jonat123 <54025331+jonat123@users.noreply.github.com>
Co-authored-by: jonat123 <54025331+jonat123@users.noreply.github.com>
Co-authored-by: jonat123 <54025331+jonat123@users.noreply.github.com>
Co-authored-by: jonat123 <54025331+jonat123@users.noreply.github.com>
Contributor
Author
|
Thank you for the review @jonat123 💪 I have applied your suggestions so am merging this in 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you add/update/change?
replacement for ContentXPath in v14 is IContentLastChanceFinder so I have updated the article accordingly.
Added to the article that is a work in progress only cuz there are some links in the article that will not work until we add the rest of the articles to summary.md, which will be around release time. (as currently we only add articles that have been updated in v14)
related to #6006 as well
Type of suggestion
Product & version (if relevant)
cms v14
Deadline (if relevant)
When should the content be published?
anytime