From 5bd56f3c9af4e21d6aa7b66f2da6b50ec7039993 Mon Sep 17 00:00:00 2001 From: Ronald Barendse Date: Thu, 11 Jul 2024 15:02:28 +0200 Subject: [PATCH 1/9] Add release notes for Deploy 13.1.1 and 14.0.2 --- 13/umbraco-deploy/release-notes.md | 7 +++++++ 14/umbraco-deploy/release-notes.md | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/13/umbraco-deploy/release-notes.md b/13/umbraco-deploy/release-notes.md index 60ea8105fff..2c57c134d5d 100644 --- a/13/umbraco-deploy/release-notes.md +++ b/13/umbraco-deploy/release-notes.md @@ -17,6 +17,13 @@ If you are upgrading to a new major version you can find the details about the b This section contains the release notes for Umbraco Deploy 13 including all changes for this version. +#### [13.1.1](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.1.1) (July 11th 2024) + +* Add `[DisableRequestSizeLimit]` attribute to `UploadForImport` endpoint to remove application request size limit (server/infrastructure restrictions may still apply) +* Determine missing `routePath` based on `$routeParams` to fix Export, Queue for transfer and Partial Restore actions on items with children in a list view +* Set trashed state when processing content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) +* Improve exception message when parent can't be found when getting artifact (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) + #### [13.1.0](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.1.0) (March 19th 2024) * All items from 13.1.0-rc1 diff --git a/14/umbraco-deploy/release-notes.md b/14/umbraco-deploy/release-notes.md index 00fe46cbe44..b8a2abef2c9 100644 --- a/14/umbraco-deploy/release-notes.md +++ b/14/umbraco-deploy/release-notes.md @@ -18,6 +18,13 @@ If you are upgrading to a new major version you can find the details about the b This section contains the release notes for Umbraco Deploy 13 including all changes for this version. +#### [14.0.2](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.2) (July 11th 2024) + +* Set trashed state when processing content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) +* Improve exception message when parent can't be found when getting artifact (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) +* Add `MaxRequestLength` Deploy setting to break file upload into multiple requests +* Set variant names when creating new content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/222) + #### [14.0.1](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.1) (June 6th 2024) * Ensure remote tree uses correct entity type (if multiple entities like folders and items are present in a tree): From 25cba0e6bed0722de6c7a8c4252da55df314454d Mon Sep 17 00:00:00 2001 From: Ronald Barendse Date: Thu, 11 Jul 2024 15:45:05 +0200 Subject: [PATCH 2/9] Add MaxRequestLength configuration setting --- 14/umbraco-deploy/getting-started/deploy-settings.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/14/umbraco-deploy/getting-started/deploy-settings.md b/14/umbraco-deploy/getting-started/deploy-settings.md index a0acc2f030d..f6bbb51814c 100644 --- a/14/umbraco-deploy/getting-started/deploy-settings.md +++ b/14/umbraco-deploy/getting-started/deploy-settings.md @@ -48,6 +48,7 @@ For illustration purposes, the following structure represents the full set of op "DiskOperationsTimeout": "0.0:05:00", "SourceDeployBatchSize": null, "PackageBatchSize": null, + "MaxRequestLength": null, "UseDatabaseBackedTransferQueue": true, "IgnoreBrokenDependenciesBehavior": "Restore", "AcceptInvalidCertificates": false, @@ -180,6 +181,12 @@ If encountering this issue, there are two batch settings that can be applied wit * `SourceDeployBatchSize` - applies a batch setting for the transfer of multiple selected items to an upstream environment (such as a media folder with many images). * `PackageBatchSize` - applies a batch setting to the processing of a Deploy "package", which contains all the items selected for a Deploy operation, plus all the determined dependencies and relations. +### MaxRequestLength + +When Deploy transfers files between environments that can't connect to each other (like a local environment that isn't exposed publicly), it falls back from fetching/downloading the files to uploading them. This is done in fixed-sized chunks, so multiple files can be combined in a single request or a large file into multiple requests. This setting can specify the size of these chuncks **(in bytes)**. + +If no value is set, Deploy will create 16MB chunks, unless the [CMS `MaxRequestLength` setting](../../umbraco-cms/reference/configuration/runtimesettings.md) is set to a lower value (note that the CMS setting is configured in kilobytes). Setting this to a value higher than the CMS `MaxRequestLength` (multiplied by 1024) will cause a validation error. Similarly, configuring a value that is higher than the [server or infrastructure allows](../../umbraco-cms/reference/configuration/maximumuploadsizesettings.md) will result in file transfers failing. + ### UseDatabaseBackedTransferQueue In earlier versions of Umbraco Deploy, the transfer queue was implemented using in-memory storage. As a result, it would not be persisted across application restarts. From d0b36078a0eda3d716f88aac15a2603d3bd58bc8 Mon Sep 17 00:00:00 2001 From: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:38:37 +0200 Subject: [PATCH 3/9] Update 13/umbraco-deploy/release-notes.md --- 13/umbraco-deploy/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-deploy/release-notes.md b/13/umbraco-deploy/release-notes.md index 2c57c134d5d..ced96de96ac 100644 --- a/13/umbraco-deploy/release-notes.md +++ b/13/umbraco-deploy/release-notes.md @@ -20,7 +20,7 @@ This section contains the release notes for Umbraco Deploy 13 including all chan #### [13.1.1](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.1.1) (July 11th 2024) * Add `[DisableRequestSizeLimit]` attribute to `UploadForImport` endpoint to remove application request size limit (server/infrastructure restrictions may still apply) -* Determine missing `routePath` based on `$routeParams` to fix Export, Queue for transfer and Partial Restore actions on items with children in a list view +* Determine missing `routePath` based on `$routeParams` to fix Export, Queue for transfer, and Partial Restore actions on items with children in a list view * Set trashed state when processing content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) * Improve exception message when parent can't be found when getting artifact (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) From fffceb7a30bf4ae0f897299a3d4f209c699c6184 Mon Sep 17 00:00:00 2001 From: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:38:43 +0200 Subject: [PATCH 4/9] Update 13/umbraco-deploy/release-notes.md --- 13/umbraco-deploy/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-deploy/release-notes.md b/13/umbraco-deploy/release-notes.md index ced96de96ac..53d500c509e 100644 --- a/13/umbraco-deploy/release-notes.md +++ b/13/umbraco-deploy/release-notes.md @@ -21,7 +21,7 @@ This section contains the release notes for Umbraco Deploy 13 including all chan * Add `[DisableRequestSizeLimit]` attribute to `UploadForImport` endpoint to remove application request size limit (server/infrastructure restrictions may still apply) * Determine missing `routePath` based on `$routeParams` to fix Export, Queue for transfer, and Partial Restore actions on items with children in a list view -* Set trashed state when processing content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) +* Set trashed state when processing content [223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) * Improve exception message when parent can't be found when getting artifact (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) #### [13.1.0](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.1.0) (March 19th 2024) From 56480fa32f492b2f95df68df4c5c76cda6cf4a79 Mon Sep 17 00:00:00 2001 From: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:38:50 +0200 Subject: [PATCH 5/9] Update 13/umbraco-deploy/release-notes.md --- 13/umbraco-deploy/release-notes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/13/umbraco-deploy/release-notes.md b/13/umbraco-deploy/release-notes.md index 53d500c509e..f1ff23365db 100644 --- a/13/umbraco-deploy/release-notes.md +++ b/13/umbraco-deploy/release-notes.md @@ -22,7 +22,7 @@ This section contains the release notes for Umbraco Deploy 13 including all chan * Add `[DisableRequestSizeLimit]` attribute to `UploadForImport` endpoint to remove application request size limit (server/infrastructure restrictions may still apply) * Determine missing `routePath` based on `$routeParams` to fix Export, Queue for transfer, and Partial Restore actions on items with children in a list view * Set trashed state when processing content [223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) -* Improve exception message when parent can't be found when getting artifact (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) +* Improve exception message when parent cannot be found when getting artifact [216](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) #### [13.1.0](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.1.0) (March 19th 2024) From 729bbb5434e4ce0e6057b6af5363524c62313e76 Mon Sep 17 00:00:00 2001 From: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:39:02 +0200 Subject: [PATCH 6/9] Update 14/umbraco-deploy/release-notes.md --- 14/umbraco-deploy/release-notes.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/14/umbraco-deploy/release-notes.md b/14/umbraco-deploy/release-notes.md index b8a2abef2c9..254e45a482b 100644 --- a/14/umbraco-deploy/release-notes.md +++ b/14/umbraco-deploy/release-notes.md @@ -20,10 +20,10 @@ This section contains the release notes for Umbraco Deploy 13 including all chan #### [14.0.2](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.2) (July 11th 2024) -* Set trashed state when processing content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) -* Improve exception message when parent can't be found when getting artifact (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) +* Set trashed state when processing content [223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) +* Improve exception message when parent can't be found when getting artifact [216](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) * Add `MaxRequestLength` Deploy setting to break file upload into multiple requests -* Set variant names when creating new content (https://github.com/umbraco/Umbraco.Deploy.Issues/issues/222) +* Set variant names when creating new content [222](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/222) #### [14.0.1](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.1) (June 6th 2024) From 7049f308dd109bcfef44a36eceb438261fba051a Mon Sep 17 00:00:00 2001 From: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:41:02 +0200 Subject: [PATCH 7/9] Update 13/umbraco-deploy/release-notes.md --- 13/umbraco-deploy/release-notes.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/13/umbraco-deploy/release-notes.md b/13/umbraco-deploy/release-notes.md index f1ff23365db..40c1eee0b83 100644 --- a/13/umbraco-deploy/release-notes.md +++ b/13/umbraco-deploy/release-notes.md @@ -21,8 +21,8 @@ This section contains the release notes for Umbraco Deploy 13 including all chan * Add `[DisableRequestSizeLimit]` attribute to `UploadForImport` endpoint to remove application request size limit (server/infrastructure restrictions may still apply) * Determine missing `routePath` based on `$routeParams` to fix Export, Queue for transfer, and Partial Restore actions on items with children in a list view -* Set trashed state when processing content [223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) -* Improve exception message when parent cannot be found when getting artifact [216](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) +* Set trashed state when processing content [#223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) +* Improve exception message when parent cannot be found when getting artifact [#216](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) #### [13.1.0](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F13.1.0) (March 19th 2024) From 7ec5c94ecc97f37c2b3e91b5cb7dc155d6d408c5 Mon Sep 17 00:00:00 2001 From: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> Date: Fri, 12 Jul 2024 10:42:10 +0200 Subject: [PATCH 8/9] Update 14/umbraco-deploy/release-notes.md --- 14/umbraco-deploy/release-notes.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/14/umbraco-deploy/release-notes.md b/14/umbraco-deploy/release-notes.md index 254e45a482b..b1b30b80688 100644 --- a/14/umbraco-deploy/release-notes.md +++ b/14/umbraco-deploy/release-notes.md @@ -20,10 +20,10 @@ This section contains the release notes for Umbraco Deploy 13 including all chan #### [14.0.2](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.2) (July 11th 2024) -* Set trashed state when processing content [223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) -* Improve exception message when parent can't be found when getting artifact [216](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) +* Set trashed state when processing content [#223](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/223) +* Improve exception message when parent can't be found when getting artifact [#216](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/216) * Add `MaxRequestLength` Deploy setting to break file upload into multiple requests -* Set variant names when creating new content [222](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/222) +* Set variant names when creating new content [#222](https://github.com/umbraco/Umbraco.Deploy.Issues/issues/222) #### [14.0.1](https://github.com/umbraco/Umbraco.Deploy.Issues/issues?q=is%3Aissue+is%3Aclosed+label%3Arelease%2F14.0.1) (June 6th 2024) From 2e3deef06f13c132bb3fcc43c022d5c8e0027638 Mon Sep 17 00:00:00 2001 From: Ronald Barendse Date: Fri, 12 Jul 2024 11:00:52 +0200 Subject: [PATCH 9/9] Update MaxRequestLength description Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com> --- 14/umbraco-deploy/getting-started/deploy-settings.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/14/umbraco-deploy/getting-started/deploy-settings.md b/14/umbraco-deploy/getting-started/deploy-settings.md index f6bbb51814c..bc886cdbe88 100644 --- a/14/umbraco-deploy/getting-started/deploy-settings.md +++ b/14/umbraco-deploy/getting-started/deploy-settings.md @@ -183,9 +183,9 @@ If encountering this issue, there are two batch settings that can be applied wit ### MaxRequestLength -When Deploy transfers files between environments that can't connect to each other (like a local environment that isn't exposed publicly), it falls back from fetching/downloading the files to uploading them. This is done in fixed-sized chunks, so multiple files can be combined in a single request or a large file into multiple requests. This setting can specify the size of these chuncks **(in bytes)**. +When Deploy transfers files between unconnected environments (like a non-public local environment), it falls back from fetching/downloading the files to uploading them. This is done in fixed-sized chunks, so multiple files can be combined in a single request or a large file into multiple requests. This setting can specify the size of these chunks **(in bytes)**. -If no value is set, Deploy will create 16MB chunks, unless the [CMS `MaxRequestLength` setting](../../umbraco-cms/reference/configuration/runtimesettings.md) is set to a lower value (note that the CMS setting is configured in kilobytes). Setting this to a value higher than the CMS `MaxRequestLength` (multiplied by 1024) will cause a validation error. Similarly, configuring a value that is higher than the [server or infrastructure allows](../../umbraco-cms/reference/configuration/maximumuploadsizesettings.md) will result in file transfers failing. +If no value is set, Deploy will create 16MB chunks, unless the [CMS `MaxRequestLength` setting](../../umbraco-cms/reference/configuration/runtimesettings.md) is lower (CMS setting is configured in kilobytes). Setting a value higher than the CMS `MaxRequestLength` (multiplied by 1024) will cause a validation error. Similarly, configuring a value higher than the [server or infrastructure limits](../../umbraco-cms/reference/configuration/maximumuploadsizesettings.md) will result in file transfers failures. ### UseDatabaseBackedTransferQueue