Notes on renamed pickers #6317
Merged
Notes on renamed pickers #6317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekelleher
approved these changes
Aug 1, 2024
Member
leekelleher
left a comment
leekelleher
left a comment
There was a problem hiding this comment.
@sofietoft Looks good to me. 👍 Thank you! 🙏
A note on how we're using the word "Content" in the backoffice UI/code, it's as an umbrella term for either Document, Media or Members.
Of course, we still have the "Content" section (for managing Documents), which will still confuse matters. 😕 I'm sure these will be straightened out in due course.
Contributor
Author
|
Good point @leekelleher ! Does it make sense to add this to note as well? |
Member
|
@sofietoft Makes sense. 👍👍 |
eshanrnh
approved these changes
Aug 2, 2024
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
The PR looks great, @sofietoft 🙌 Just a few quick suggestions for you to check out😊
...fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/content-picker.md
Outdated
Show resolved
Hide resolved
...fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/content-picker.md
Outdated
Show resolved
Hide resolved
...fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/content-picker.md
Outdated
Show resolved
Hide resolved
...undamentals/backoffice/property-editors/built-in-umbraco-property-editors/document-picker.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Contributor
Author
|
Thanks for the review @sofietoft ! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notes to the renamed Content Picker and Document Picker to avoid confusion.