Added limitations section in Manage Hostnames article #7001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @Musealali ! Thanks for the PR. |
eshanrnh
reviewed
Apr 3, 2025
umbraco-cloud/set-up/project-settings/manage-hostnames/README.md
Outdated
Show resolved
Hide resolved
eshanrnh
requested changes
Apr 3, 2025
Contributor
There was a problem hiding this comment.
Thanks for the PR, @Musealali 💪 I've made a small suggestion to change the Note type to Warning and add inline code tags for /umbraco.
Co-authored-by: Esha Noronha <82437098+eshanrnh@users.noreply.github.com>
Contributor
Author
|
Sorry - Will try to remember next time. |
Contributor
Author
|
I actually erased that warning / info thing - just talked with the team and they really like a limitations section just like in the database backups docs - so I've gone with that flow instead 😄 |
eshanrnh
approved these changes
Apr 4, 2025
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
Looks good to me, @Musealali 🙌
eshanrnh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What did you add/update/change?
Type of suggestion
Product & version (if relevant)
Deadline (if relevant)
When should the content be published?