Add Deploy 4.9, 10.3, 12.1 and 13.0 release notes and configuration details for TrashedContentDeploymentOperations
#5732
Conversation
| "ApiKey": "<your API key here>", | ||
| "ApiSecret": "<your API secret here>", | ||
| "Edition": "Default", | ||
| "DefaultTimeoutSeconds": 60, |
There was a problem hiding this comment.
This isn't a configurable setting, but a read-only constant field with the default timeout used by other settings...
There was a problem hiding this comment.
ah, makes sense! should I remove this setting in all other deploy versions as well?
There was a problem hiding this comment.
and would it perhaps make better sense to remove this setting and add a warning or info note at the end of the "timeout settings" https://docs.umbraco.com/umbraco-deploy/v/12.deploy.latest/deploy-settings#timeout-settings that "DefaultTimeoutSeconds is set to default of 60 seconds. This isn't a configurable setting, but a read-only constant field with the default timeout used by other settings"?
There was a problem hiding this comment.
DefaultTimeoutSeconds should be removed from the documentation for all versions, because it's not a setting at all and because it's an internal constant, also isn't available externally (besides actually being set to 20 * 60, so 20 minutes, which is already documented in the timeout settings section).
| "RelationTypes": [ | ||
| { | ||
| "Alias": "relateParentDocumentOnDelete", | ||
| "Mode": "Weak", | ||
| }, | ||
| { | ||
| "Alias": "relateShopItemOnCreate", | ||
| "Mode": "Exclude", | ||
| } | ||
| ], |
There was a problem hiding this comment.
The format of this setting has changed in v13 (see breaking changes) and is already shown below...
There was a problem hiding this comment.
should this be removed only for v13 or for all versions?
There was a problem hiding this comment.
Only for v13, as that uses the format that's already shown below.
alina-tincas
left a comment
alina-tincas
left a comment
There was a problem hiding this comment.
Hi @ronaldbarendse thank you for the PR! I have few suggestions can you please look into them and let me know what you think? 😊
| "ApiKey": "<your API key here>", | ||
| "ApiSecret": "<your API secret here>", | ||
| "Edition": "Default", | ||
| "DefaultTimeoutSeconds": 60, |
There was a problem hiding this comment.
ah, makes sense! should I remove this setting in all other deploy versions as well?
alina-tincas
left a comment
alina-tincas
left a comment
There was a problem hiding this comment.
Hi @ronaldbarendse! Happy New Year! 🎉
Andy has created a new PR adding the release notes and configurations here: #5750
I have noted down in this PR what has been added in Andy´s PR from here, and if you let me know on the other comments if the other changes need to be made to v13 or the others and if you do not have the time, I can make those changes 💪 Let me know!
|
|
||
| ```json | ||
| "ExcludedEntityTypes": ['media-file'], | ||
| "ExcludedEntityTypes": ["media-file"], |
There was a problem hiding this comment.
should this be changed only for v13 or for all versions?
There was a problem hiding this comment.
This should be updated for all versions, because for JSON to be 100% valid, it needs to use double quotes 😄
| "RelationTypes": [ | ||
| { | ||
| "Alias": "relateParentDocumentOnDelete", | ||
| "Mode": "Weak", | ||
| }, | ||
| { | ||
| "Alias": "relateShopItemOnCreate", | ||
| "Mode": "Exclude", | ||
| } | ||
| ], |
There was a problem hiding this comment.
should this be removed only for v13 or for all versions?
| } | ||
| } | ||
| } | ||
| "PreferLocalDbConnectionString": true |
There was a problem hiding this comment.
should this be changed only for v13 or for all versions?
There was a problem hiding this comment.
This can be updated for all versions: other code examples also don't show the Umbraco:Deploy:Settings part (as that's already mentioned at the top of the article)...
| "ApiKey": "<your API key here>", | ||
| "ApiSecret": "<your API secret here>", | ||
| "Edition": "Default", | ||
| "DefaultTimeoutSeconds": 60, |
There was a problem hiding this comment.
and would it perhaps make better sense to remove this setting and add a warning or info note at the end of the "timeout settings" https://docs.umbraco.com/umbraco-deploy/v/12.deploy.latest/deploy-settings#timeout-settings that "DefaultTimeoutSeconds is set to default of 60 seconds. This isn't a configurable setting, but a read-only constant field with the default timeout used by other settings"?
|
HI @ronaldbarendse thank you for confirming what changes need to be made on which versions! I have manually made the changes therefore am closing this PR 💪 |
ronaldbarendse
deleted the
deploy/release-notes-trashedcontentdeployoperations
branch
2 participants
Description
Updated release notes for Deploy 4.9, 10.3, 12.1 and 13.0, including updates to previous RCs and added configuration details for
TrashedContentDeploymentOperations.Type of suggestion
Product & version (if relevant)
Umbraco Deploy 4.9, 10.3, 12.1 and 13.0
Deadline (if relevant)
All these version are already released, so this can be published when reviewed/ready.