Skip to content

Conversation

@jmf-umbraco
Copy link
Contributor

@jmf-umbraco jmf-umbraco commented Sep 24, 2024

Description

Heartcore release notes & updated API docs for September.

Also moved the redirect API to underneath the content delivery API - It's not really a seperate API on its own and the docs should reflect that.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Heartcore

Deadline (if relevant)

When should the content be published?

N/A

@jmf-umbraco jmf-umbraco marked this pull request as ready for review September 25, 2024 08:01
Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jmf-umbraco ! 💪

I've made some suggestions, mainly to keep the content consistent with the rest of our docs 🙌

Also, could I get you to add the following line to the .gitbook.yaml file in the umbraco-heartcore directory:

api-documentation/redirect: api-documentation/content-delivery/redirect.md

^ It's a redirect for the article that was moved 💪

Finally, let me know when this should be merged - thanks!

@jmf-umbraco
Copy link
Contributor Author

@sofietoft - Those suggestions all make sense to me, I'll commit them. And absolutely will add the redirect. I was going to ask about how we typically handle those, but I figured it would come up during review, so thanks for the info 😆

@jmf-umbraco
Copy link
Contributor Author

Changes made. The new redirect endpoint goes out tomorrow, so any time from then onwards is fine.

@sofietoft
Copy link
Contributor

Thanks for considering the suggestions @jmf-umbraco ! 😄
I just added a missing "redirects" heading to the yaml file - I thought it was already there 😅

But all looks good 👏
I'll get it merged once all the checks clears!

@sofietoft sofietoft merged commit 7465ff4 into umbraco:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants