Umbraco UI Builder release notes and details on entity identifier type converters #7006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR, @acoumb 🙌 We will look at it as soon as we can. |
Contributor
|
Hey @acoumb 👋, Can you please add the entity-identifier-converters.md article to the SUMMARY.md file so that it appears in the navigation pane? |
Contributor
Author
|
@eshanrnh Updated. Thanks |
eshanrnh
requested changes
Apr 7, 2025
Contributor
eshanrnh
left a comment
eshanrnh
left a comment
There was a problem hiding this comment.
The PR looks great, @acoumb 🙌I've added a couple of suggestions to shorten long sentences (Vale errors) and apply some general style guide fixes.
Do you want me to incorporate these kinds of suggestions myself going forward, or will you take care of them?
13/umbraco-ui-builder/collections/entity-identifier-converters.md
Outdated
Show resolved
Hide resolved
13/umbraco-ui-builder/collections/entity-identifier-converters.md
Outdated
Show resolved
Hide resolved
13/umbraco-ui-builder/collections/entity-identifier-converters.md
Outdated
Show resolved
Hide resolved
15/umbraco-ui-builder/collections/entity-identifier-converters.md
Outdated
Show resolved
Hide resolved
15/umbraco-ui-builder/collections/entity-identifier-converters.md
Outdated
Show resolved
Hide resolved
15/umbraco-ui-builder/collections/entity-identifier-converters.md
Outdated
Show resolved
Hide resolved
Contributor
Author
|
If you're already working with the PR, it's fine with me for you to take care of them. Thank you for the assistance. |
eshanrnh
reviewed
Apr 7, 2025
eshanrnh
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EntityIdentifierTypeConvertersType of suggestion
Product & version (if relevant)
Umbraco UI Builder 13.2.3 and 15.1.2
Deadline (if relevant)
When possible.