This repository has been archived by the owner on Dec 13, 2021. It is now read-only.
Testing IPublishedContent with IsEnumerableOfType extension method #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst experimenting with returning collections of a custom `IPublishedContent` class, Ditto wouldn't attempt to cast/map them any further. I set up a quick unit-test to see if this was the case... ``` typeof(IEnumerable<Mocks.PublishedContentMock>).IsEnumerableOfType(typeof(IPublishedContent)) ``` Should this be true or false? --- I've added in a fix that swaps around the params for the `IsAssignableFrom` check.
|
Yeah, in my mind that should return true. I'll double check against the tests etc to make sure your fix doesn't have any unforseen side effects. |
|
Thanks @JimBobSquarePants! This came about when I was reviewing a Merchello/Ditto workshop implementation. Merchello has an The other unit-tests all pass, which either means the patch is cool... or we're missing test scenarios 馃槈 (gotta test 'em all!) |
|
@JimBobSquarePants No pressure, just curious if you've had chance to look this one? |
|
Sorry... Yeah, looks good to me! |
leekelleher
added a commit
that referenced
this pull request
Nov 13, 2015
Testing IPublishedContent with IsEnumerableOfType extension method
|
Cool, merged in! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @JimBobSquarePants, here's one for you 馃樇
Whilst experimenting with returning collections of a custom
IPublishedContentclass, Ditto wouldn't attempt to cast/map them any further.I set up a quick unit-test to see if this was the case... (where
PublishedContentMockis a custom implementation ofIPublishedContent)Should this be true or false?
I've added in a fix that swaps around the params for the
IsAssignableFromcheck.