New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove the last tab in version v7.8 #89

Closed
wants to merge 1 commit into
base: develop
from

Conversation

5 participants
@dawoe
Contributor

dawoe commented Feb 12, 2018

This PR fixes issue #88

In v7.8 the info tab is not present in the response from contentResource.getScaffold.

So we don't need to remove the last tab

Dave

@dawoe dawoe referenced this pull request Feb 12, 2018

Closed

Edit pane stays empty in v7.8 #88

@markglibres

will this work inside the existing loop inside?

if (!data.tabs[t].active) { continue; }

@@ -206,8 +206,16 @@ angular.module("umbraco").controller("Our.Umbraco.DocTypeGridEditor.Dialogs.DocT
function loadNode() {
contentResource.getScaffold(-20, $scope.model.dialogData.docTypeAlias).then(function (data) {
// Remove the last tab
data.tabs.pop();

This comment has been minimized.

@markglibres

markglibres Feb 13, 2018

i think this will do inside the existing loop.. whatcha think?

if (!data.tabs[t].active) { continue; }

@markglibres

markglibres Feb 13, 2018

i think this will do inside the existing loop.. whatcha think?

if (!data.tabs[t].active) { continue; }

This comment has been minimized.

@dawoe

dawoe Feb 14, 2018

Contributor

@markglibres what loop are you talking about

@meregan what exactly does not work for you ? Because i see a report of the fix working here : https://our.umbraco.org/projects/backoffice-extensions/doc-type-grid-editor/doc-type-grid-editor-feedback/90527-dtge-dialog-editor-empty-in-umbraco-781

@dawoe

dawoe Feb 14, 2018

Contributor

@markglibres what loop are you talking about

@meregan what exactly does not work for you ? Because i see a report of the fix working here : https://our.umbraco.org/projects/backoffice-extensions/doc-type-grid-editor/doc-type-grid-editor-feedback/90527-dtge-dialog-editor-empty-in-umbraco-781

This comment has been minimized.

@markglibres

markglibres Feb 18, 2018

@dawoe the loop after it pops the last tab. i just noticed that umbraco api returns active=false for the properties tab on older versions, and no info tab on the latest release.

@markglibres

markglibres Feb 18, 2018

@dawoe the loop after it pops the last tab. i just noticed that umbraco api returns active=false for the properties tab on older versions, and no info tab on the latest release.

@dawoe

This comment has been minimized.

Show comment
Hide comment
@dawoe

dawoe Feb 14, 2018

Contributor

@leekelleher @mattbrailsford any timeline when this will be merged ?

This issue (#88) prevents the use of DTGE in v7.8

Contributor

dawoe commented Feb 14, 2018

@leekelleher @mattbrailsford any timeline when this will be merged ?

This issue (#88) prevents the use of DTGE in v7.8

@leekelleher

This comment has been minimized.

Show comment
Hide comment
@leekelleher

leekelleher Feb 14, 2018

Member

@dawoe I won't be able to look at it until next week (I'm currently on jury duty ⚖️👩‍⚖️). I'm not sure of @mattbrailsford's availablity.

Member

leekelleher commented Feb 14, 2018

@dawoe I won't be able to look at it until next week (I'm currently on jury duty ⚖️👩‍⚖️). I'm not sure of @mattbrailsford's availablity.

@leekelleher leekelleher self-assigned this Feb 14, 2018

@mattbrailsford

This comment has been minimized.

Show comment
Hide comment
@mattbrailsford

mattbrailsford Feb 14, 2018

Collaborator

Fixed a different way via commit ac98e71

Collaborator

mattbrailsford commented Feb 14, 2018

Fixed a different way via commit ac98e71

@leekelleher

This comment has been minimized.

Show comment
Hide comment
@leekelleher

leekelleher Feb 14, 2018

Member

@dawoe Thanks for your PR though, is it appreciated! 🙌 🤘

Member

leekelleher commented Feb 14, 2018

@dawoe Thanks for your PR though, is it appreciated! 🙌 🤘

@naepalm

This comment has been minimized.

Show comment
Hide comment
@naepalm

naepalm Feb 15, 2018

@mattbrailsford When can we expect a release with that fix in it? ;)

naepalm commented Feb 15, 2018

@mattbrailsford When can we expect a release with that fix in it? ;)

@leekelleher leekelleher added this to the 0.5.0 milestone Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment