Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write docs to raise awareness of the "System Property Keys" #31

Closed
leekelleher opened this issue Jul 6, 2018 · 0 comments

Comments

1 participant
@leekelleher
Copy link
Member

commented Jul 6, 2018

Using a property alias such as "icon" can burn users, see Our Umbraco forum post for an example.

As of v1.1.1 (time of writing), we have the following...

private static bool IsSystemPropertyKey(string propKey)
{
    return propKey == "name"
        || propKey == "children"
        || propKey == "key"
        || propKey == "icon"
        || propKey == InnerContentConstants.ContentTypeGuidPropertyKey
        || propKey == InnerContentConstants.ContentTypeAliasPropertyKey;
}

ref: https://github.com/umco/umbraco-inner-content/blob/1.1.1/src/Our.Umbraco.InnerContent/PropertyEditors/InnerContentPropertyValueEditorWrapper.cs#L235-L243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.