Skip to content

All file names are not valid global properties identifiers. #3

Closed
wants to merge 1 commit into from

2 participants

@johnjbarton

The match between file names and global var names stumbles if the file name has a dash.

@jrburke
UMD member
jrburke commented Jan 20, 2013

I am so sorry, apparently github notifications were turned off for me on this repo and just now seeing this. Very, very late to it.

While this is true, I feel that is more of an edge case. Since this pull request was done too, the code has moved so that the merge does not apply cleanly, and there are a few example files in this repo that would need this change. If you are open to do doing a new pull request and including those other files, I can merge it. Closing this one though, just because the code as morphed since original posting.

@jrburke jrburke closed this Jan 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.