Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add performance timing log #603

Merged
merged 1 commit into from May 25, 2020
Merged

✨ add performance timing log #603

merged 1 commit into from May 25, 2020

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented May 25, 2020 •
edited

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

This change is Reviewable

@kuitos kuitos requested a review from howel52 May 25, 2020 07:30
howel52
howel52 reviewed May 25, 2020
View reviewed changes
src/loader.ts Show resolved Hide resolved
@howel52
Copy link
Collaborator

howel52 commented May 25, 2020

感觉标题不太对，如果是提供 timing api 的话，这个 api 应该是要暴露给业务使用的吧

@kuitos kuitos changed the title ✨ add performance timing api ✨ add performance timing log May 25, 2020
@kuitos
Copy link
Member Author

kuitos commented May 25, 2020

感觉标题不太对，如果是提供 timing api 的话，这个 api 应该是要暴露给业务使用的吧

有道理，改了

@howel52 howel52 merged commit 9d22383 into master May 25, 2020
@howel52 howel52 deleted the feat/add-log branch May 25, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howel52 howel52 howel52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuitos @howel52