fix: webpack-chain types #2765
Merged
fix: webpack-chain types #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycjcl868
commented
Jul 6, 2019
packages/umi-types/config.d.ts
Outdated
| externalWhitelist?: WhitelistOption[]; | ||
| } | ||
| export type IExportSSROpts = | ||
| | { |
There was a problem hiding this comment.
@chenshuai2144 prettier format 下会在前面加个 |
There was a problem hiding this comment.
prettier/prettier#2069 ，会有影响
Pull Request Test Coverage Report for Build 4479
💛 - Coveralls |
sorrycc
reviewed
Jul 7, 2019
| @@ -8,7 +8,7 @@ import nodeExternals from 'webpack-node-externals'; | |||
| const debug = require('debug')('umi-build-dev:getWebpackConfig'); | |||
|
|
|||
| interface IOpts { | |||
| ssr?: boolean | IExportSSROpts; | |||
ycjcl868
commented
Jul 7, 2019
| | { | ||
| externalWhitelist?: WhitelistOption[]; | ||
| } | ||
| | boolean; | ||
|
|
kuitos
pushed a commit
to kuitos/umi
that referenced
this pull request
Jul 23, 2019
* fix: webpack-chain types * fix: types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2752.