Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lqt_seek_video not being used #238

Closed
agraef opened this issue Aug 28, 2019 · 2 comments

Comments

@agraef
Copy link

commented Aug 28, 2019

Maybe this is just old cruft not being utilized any more (then it's probably better to remove it), or maybe it's intentional. But right now lqt_seek_video isn't being used at all. Looking at:

#ifdef HAVE_QUICKTIME_SEEK_VIDEO

Here's the code:

#ifdef HAVE_QUICKTIME_SEEK_VIDEO
  lqt_seek_video        (m_quickfile, m_curTrack, m_curFrame, m_curTrack);
#else
  if ((quicktime_set_video_position(m_quickfile, m_curFrame,
                                      m_curTrack))) {  }
#endif
  return film::SUCCESS;

There are a number of issues here:

  1. The config.h symbol to test for is HAVE_LQT_SEEK_VIDEO, not HAVE_QUICKTIME_SEEK_VIDEO.

  2. The lqt.h header needs to be included in the filmQT4L.h file to get the declaration of this function.

  3. lqt_seek_video takes three parameters, not four.

  4. If you're using that function, maybe you should be using lqt_video_duration in lieu of quicktime_video_length as well (at least that's what the libquicktime doxygen docs indicate).

I'm not saying that this should be enabled, probably it's better to keep it the way it is, in order to not break this backend. It's just something I came across while studying the QT4L source code, and left me scratching my head wondering whether this was supposed to be working.

@umlaeute

This comment has been minimized.

Copy link
Owner

commented Aug 29, 2019

:-) good catch. it's been lingering for 9 years :-)
PR for fixing the issue is welcome

@umlaeute

This comment has been minimized.

Copy link
Owner

commented Sep 16, 2019

Closed with 1ab32e4...6a8ae7d

@umlaeute umlaeute closed this Sep 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.