New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agressive validation checks when UmpleOnline text is edited to only change comment or spaces #1300

Closed
TimLethbridge opened this Issue Jun 13, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@TimLethbridge
Member

TimLethbridge commented Jun 13, 2018

There used to be a check such that when editing the text in UmpleOnline, no submission for validation was done if the only change was change to add spaces or to change the contents of a comment (maybe just a // comment). This lowered the load on the server, and also helped users working on low-bandwidth connections. However this check has been turned off.

This was likely in umple_action.js umpleTypingActivity or processTyping. We should check back in git history to see if we can understand if there was a legitimate reason why this was removed.

@TimLethbridge

This comment has been minimized.

Member

TimLethbridge commented Aug 29, 2018

This seems to not be a problem. Such edits appear not to be submitted to the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment