Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in methods and injections in Ruby should use # #1487

Open
TimLethbridge opened this issue Aug 12, 2019 · 0 comments

Comments

@TimLethbridge
Copy link
Member

commented Aug 12, 2019

The following example shows that comments embedded in methods retain java style comment notation. This might be acceptable because the end-user can write different versions for each language. However it still might be useful to convert // to #

A worse problem is auto-generated comments on code injections. For these the # must be used.

Example code that generates problems in Ruby

// This is a test class
class X {
  a; // This is a test attribute
  m1 () {
    // test 
  }
  
  after custom m1() {
    // test injection
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.