New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State machine code generation issuing incorrect warning for duplicate state transitions #690

Closed
mkmicik opened this Issue Jan 16, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@mkmicik
Contributor

mkmicik commented Jan 16, 2016

When defining a state machine with duplicate state transitions like so:

class A{
status {
on{
turnOff() -> off;
turnOff() -> off;
}
off{
turnOn -> on;
}
}
}

warning 54 is issued. This scenario is technically allowed by the compiler and should be ignored.

@TimLethbridge

This comment has been minimized.

Member

TimLethbridge commented Jan 16, 2016

But it is true that the duplicate is ignored. I don't see this is particularly worth worrying about.

The warning was, I agree, supposed to flag cases where the destination state is different in the duplicate case, so I suppose it could be turned off if the destination is the same. But very low priority.

@vahdat-ab

This comment has been minimized.

Member

vahdat-ab commented Jan 29, 2016

@mkmicik this is going to be resolved by pay more attention to the issue #656. The same methods are responsible can be responsible for this.

@vahdat-ab

This comment has been minimized.

Member

vahdat-ab commented Apr 3, 2017

Since the second transition is detected properly and a proper warning is raised so I think this issue can be ignored. I'm closing this.

@vahdat-ab vahdat-ab closed this Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment