New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up all tests marked @Ignore #757

Open
TimLethbridge opened this Issue Feb 23, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@TimLethbridge
Member

TimLethbridge commented Feb 23, 2016

If you go to cruise.umple/test/cruise/umple and run
grep -s '@Ignore' * */* */*/* */*/*/*

You will find a lot of ignored tests.This is a big 'smell' in the project
For each, we need to:

  • Find out whether in fact the test can be reactivated (e.g. was ignored temporarily then left)
  • If so re-activate it
  • If not see if it can be modified and then reactivated, otherwise consider deleting or replacing with better tests.

Some tests were ignored because they were intermittently breaking the build due to random timing effects. These ones need special handling ... making them deterministic. That includes

cruise.queued.statemachine.test.QueuedStateMachineTest_timedTransition_1 (1)
TestName: processEvents

cruise.statemachine.test.DoActivityTest (1)
TestName: autoTransitionSyncAfterMultipleDo

cruise.queued.statemachine.test.MultipleQueuedStateMachinesTest (1)
cruise.queued.statemachine.test.QueuedStateMachineTest_timedTransition_1 (1)
cruise.statemachine.test.DoActivityTest (1)
And maybe some others.

When handling that latter type of test it is necessary to drastically overload your machine (e.g. to 200% capacity) before running the tests.

@TimLethbridge

This comment has been minimized.

Member

TimLethbridge commented Sep 20, 2016

If a test is to be deleted, rather than reactivated, or modified and then reactivated, please ask a project leader. Do each small group of changes as a small pull request so they can be reviewed.

@vahdat-ab

This comment has been minimized.

Member

vahdat-ab commented Jan 15, 2017

if you're a UCOSP student and wants to work on your first issue, it's better not to select this one. You can come back to this one when you're done with your few issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment