Activate testing of UmpleOnline and User Manual examples during the build by compiling C++/Php #758

Open
TimLethbridge opened this Issue Feb 23, 2016 · 11 comments

Comments

@TimLethbridge
Member

TimLethbridge commented Feb 23, 2016

Work was being done by @CraigBryan to ensure that all the examples in the user manual and umpleonline are compiled in the build.

This was never activated. We really need to finish that so we can keep improving the robustness

See also #363

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Feb 23, 2016

Member

I think we only need to activate this on travis, and make it optional when myenv=local

Member

TimLethbridge commented Feb 23, 2016

I think we only need to activate this on travis, and make it optional when myenv=local

@CraigBryan CraigBryan changed the title from Activate testing of UmpleOnline and User Manual examples duriing the build to Activate testing of UmpleOnline and User Manual examples during the build Feb 23, 2016

@CraigBryan CraigBryan self-assigned this Feb 27, 2016

@CraigBryan

This comment has been minimized.

Show comment
Hide comment
@CraigBryan

CraigBryan Feb 27, 2016

Contributor

@TimLethbridge What do you mean by 'optional' when myenv=local? Does that mean run when myenv=local or does it mean run when myenv=local and another variable is set?

Contributor

CraigBryan commented Feb 27, 2016

@TimLethbridge What do you mean by 'optional' when myenv=local? Does that mean run when myenv=local or does it mean run when myenv=local and another variable is set?

@CraigBryan

This comment has been minimized.

Show comment
Hide comment
@CraigBryan

CraigBryan Feb 27, 2016

Contributor

The other work that needs to be done is to add any missing flags to the manual code and example code so that the build actually passes with this enabled.

Contributor

CraigBryan commented Feb 27, 2016

The other work that needs to be done is to add any missing flags to the manual code and example code so that the build actually passes with this enabled.

@jblang94 jblang94 self-assigned this Jan 17, 2017

@jblang94

This comment has been minimized.

Show comment
Hide comment
@jblang94

jblang94 Jan 17, 2017

Contributor

Hello @CraigBryan , I am wondering if you are still working on this issue?

Contributor

jblang94 commented Jan 17, 2017

Hello @CraigBryan , I am wondering if you are still working on this issue?

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Jan 17, 2017

Member

I wouldn't worry ... It has been over a year since Craig finished doing his work; I am sure he would be happy to have someone pick this up, but he might be willing to help if there are questions.

Member

TimLethbridge commented Jan 17, 2017

I wouldn't worry ... It has been over a year since Craig finished doing his work; I am sure he would be happy to have someone pick this up, but he might be willing to help if there are questions.

@vahdat-ab

This comment has been minimized.

Show comment
Hide comment
@vahdat-ab

vahdat-ab Jan 22, 2017

Member

I need to work on the example GeometricSystem.ump. Once, I'm done I'll close this.

Member

vahdat-ab commented Jan 22, 2017

I need to work on the example GeometricSystem.ump. Once, I'm done I'll close this.

@jblang94

This comment has been minimized.

Show comment
Hide comment
@jblang94

jblang94 Jan 26, 2017

Contributor

@vahdat-ab safe to close this issue?

Contributor

jblang94 commented Jan 26, 2017

@vahdat-ab safe to close this issue?

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Feb 14, 2018

Member

This was never actually activated. I am going to activate today.

Member

TimLethbridge commented Feb 14, 2018

This was never actually activated. I am going to activate today.

@TimLethbridge TimLethbridge added this to the April 2018 for release 1.28 milestone Feb 14, 2018

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Feb 14, 2018

Member

By the way, the command to run on the command line is

ant -Dmyenv=local -f build/build.exampletests.xml allUserManualAndExampleTests
Member

TimLethbridge commented Feb 14, 2018

By the way, the command to run on the command line is

ant -Dmyenv=local -f build/build.exampletests.xml allUserManualAndExampleTests
@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Feb 14, 2018

Member

This issue is being partially dealt with in PR #1228

However that PR only activates it for Java. Note that activation is done in build/build.exampletests.xml line 46-49

Most Cpp files do not compile. The following PhP do not compile, and should be either fixed or else the @@@ skipphpcompile should be added to them, and then php should be activated.

 AssociationClassDefinition4.ump
 AssociationClassDefinition5.ump
 CarTransmission.ump
 CollisionAvoidance.ump
 CourseSectionNested.ump
 Elevator_State_Machine.ump
 NestedStateMachines1.ump
 ParliamentBill.ump
 RegionFinal_ConcurrentExample.ump
 RegionFinal_NonConcurrentExample.ump
 Runway.ump
 SpecificFlight.ump
 TracingAssociations1.ump
 TracingAssociations2.ump
 TracingAssociations3.ump
 TracingAttributes2.ump
 TracingAttributeswithConditions2.ump
 TracingAttributeswithOccurrences2.ump
 TracingStateMachines1.ump
 TracingStateMachines2.ump
 TracingStateMachines3.ump
 traits_example_018.ump
 traits_example_024.ump
 W055DuplicateEventsWithinSubstates1.ump
 W142TypeIsAccessSpecifierExplicit.ump
 W228InitialStates.ump
Member

TimLethbridge commented Feb 14, 2018

This issue is being partially dealt with in PR #1228

However that PR only activates it for Java. Note that activation is done in build/build.exampletests.xml line 46-49

Most Cpp files do not compile. The following PhP do not compile, and should be either fixed or else the @@@ skipphpcompile should be added to them, and then php should be activated.

 AssociationClassDefinition4.ump
 AssociationClassDefinition5.ump
 CarTransmission.ump
 CollisionAvoidance.ump
 CourseSectionNested.ump
 Elevator_State_Machine.ump
 NestedStateMachines1.ump
 ParliamentBill.ump
 RegionFinal_ConcurrentExample.ump
 RegionFinal_NonConcurrentExample.ump
 Runway.ump
 SpecificFlight.ump
 TracingAssociations1.ump
 TracingAssociations2.ump
 TracingAssociations3.ump
 TracingAttributes2.ump
 TracingAttributeswithConditions2.ump
 TracingAttributeswithOccurrences2.ump
 TracingStateMachines1.ump
 TracingStateMachines2.ump
 TracingStateMachines3.ump
 traits_example_018.ump
 traits_example_024.ump
 W055DuplicateEventsWithinSubstates1.ump
 W142TypeIsAccessSpecifierExplicit.ump
 W228InitialStates.ump

TimLethbridge added a commit that referenced this issue Feb 14, 2018

Merge pull request #1228 from umple/ActivateExampletests
Activation of build.exampletests.xml issue #758

@TimLethbridge TimLethbridge changed the title from Activate testing of UmpleOnline and User Manual examples during the build to Activate testing of UmpleOnline and User Manual examples during the build by compiling C++/Php Mar 23, 2018

@ZainabAlShowely

This comment has been minimized.

Show comment
Hide comment
@ZainabAlShowely

ZainabAlShowely Jul 4, 2018

Contributor

PHP code generation issues (that get triggered by the examples that do not compile) are being worked on in branch Issue_758. Tracing PHP code generation is not implemented, so these examples will be skipped until then.

Contributor

ZainabAlShowely commented Jul 4, 2018

PHP code generation issues (that get triggered by the examples that do not compile) are being worked on in branch Issue_758. Tracing PHP code generation is not implemented, so these examples will be skipped until then.

TimLethbridge added a commit that referenced this issue Jul 18, 2018

Merge pull request #1339 from umple/Issue_758
Progress on #758 Activates PHP compilation of UmpleOnline and manual examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment