New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joint.js photo sync mode should hidden icon&place holder display #1172

Merged
merged 2 commits into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@runqingz
Contributor

runqingz commented Dec 4, 2017

Description

This PR provide feature that joint.js photo ready option should hide all icon, button & place holder display when checked, and show all of these when unchecked.

Closes #1139

@Nava2

This comment has been minimized.

Show comment
Hide comment
@Nava2

Nava2 Dec 4, 2017

Member

Could you use more descriptive titles in your pull requests? It helps when searching for content. "JointJS icon visibility fixes (#1139)" would be a good one.

Member

Nava2 commented Dec 4, 2017

Could you use more descriptive titles in your pull requests? It helps when searching for content. "JointJS icon visibility fixes (#1139)" would be a good one.

@runqingz runqingz changed the title from Runqing 1139 to joint.js photo sync mode should hidden icon&place holder display Dec 4, 2017

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Dec 4, 2017

Member

I tested this. It does what it claims and is a simple agile improvement. Great. One step towards making the joint.js capability fully usable.

Member

TimLethbridge commented Dec 4, 2017

I tested this. It does what it claims and is a simple agile improvement. Great. One step towards making the joint.js capability fully usable.

@TimLethbridge TimLethbridge merged commit c253db3 into master Dec 4, 2017

3 of 4 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TimLethbridge TimLethbridge deleted the runqing_1139 branch Dec 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment