New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue for queued methods Java code generation and adds testbed test #1361

Merged
merged 3 commits into from Aug 31, 2018

Conversation

Projects
None yet
2 participants
@ZainabAlShowely
Contributor

ZainabAlShowely commented Aug 31, 2018

Corrects queued method generating non compiling code in Java.
Adds a basic testbed test checking proper execution of queued methods.

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Aug 31, 2018

Member

@ZainabAlShowely .. the appveyor test is failing with the following. Not sure if it is a bootstrapping problem (e.g. using the wrong version of the compiler to compiler new code ...).

Success! Processed C:\projects\umple\testbed\src\runtime\StateMachineEntry.ump.
1755    [javac] Compiling 139 source files to C:\projects\umple\testbed\bin
1756    [javac] C:\projects\umple\testbed\test\cruise\associations\AddAtIndexTest.java:5: error: cannot find symbol
1757    [javac] import cruise.associations.MentorAM;
1758    [javac]                           ^
1759    [javac]   symbol:   class MentorAM
1760    [javac]   location: package cruise.associations
1761    [javac] C:\projects\umple\testbed\test\cruise\associations\AddAtIndexTest.java:6: error: cannot find symbol
1762    [javac] import cruise.associations.StudentAM;
1763    [javac]                           ^
1764    [javac]   symbol:   class StudentAM
1765    [javac]   location: package cruise.associations
1766    [javac] C:\projects\umple\testbed\test\cruise\associations\AssociationClassTest.java:5: error: cannot find symbol
1767    [javac] import cruise.associations.Flight;
1768
Member

TimLethbridge commented Aug 31, 2018

@ZainabAlShowely .. the appveyor test is failing with the following. Not sure if it is a bootstrapping problem (e.g. using the wrong version of the compiler to compiler new code ...).

Success! Processed C:\projects\umple\testbed\src\runtime\StateMachineEntry.ump.
1755    [javac] Compiling 139 source files to C:\projects\umple\testbed\bin
1756    [javac] C:\projects\umple\testbed\test\cruise\associations\AddAtIndexTest.java:5: error: cannot find symbol
1757    [javac] import cruise.associations.MentorAM;
1758    [javac]                           ^
1759    [javac]   symbol:   class MentorAM
1760    [javac]   location: package cruise.associations
1761    [javac] C:\projects\umple\testbed\test\cruise\associations\AddAtIndexTest.java:6: error: cannot find symbol
1762    [javac] import cruise.associations.StudentAM;
1763    [javac]                           ^
1764    [javac]   symbol:   class StudentAM
1765    [javac]   location: package cruise.associations
1766    [javac] C:\projects\umple\testbed\test\cruise\associations\AssociationClassTest.java:5: error: cannot find symbol
1767    [javac] import cruise.associations.Flight;
1768
@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Aug 31, 2018

Member

@ZainabAlShowely It fails on my mac too after I do a first-build.

Member

TimLethbridge commented Aug 31, 2018

@ZainabAlShowely It fails on my mac too after I do a first-build.

@ZainabAlShowely

This comment has been minimized.

Show comment
Hide comment
@ZainabAlShowely

ZainabAlShowely Aug 31, 2018

Contributor

I see, I will run tests again to verify what exactly is wrong..

Contributor

ZainabAlShowely commented Aug 31, 2018

I see, I will run tests again to verify what exactly is wrong..

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Aug 31, 2018

Member

@ZainabAlShowely Actually before the Java errors, I am getting

Error 130 on line 5 of file "TestHarnessQueuedMethod.ump":
     [java] Attribute name 'String[] log' must be alphanumeric, starting with a lower-case letter

This seems to be because of an extraneous character! Would you like me to try to fix?

Member

TimLethbridge commented Aug 31, 2018

@ZainabAlShowely Actually before the Java errors, I am getting

Error 130 on line 5 of file "TestHarnessQueuedMethod.ump":
     [java] Attribute name 'String[] log' must be alphanumeric, starting with a lower-case letter

This seems to be because of an extraneous character! Would you like me to try to fix?

Fixing extraneous character
Fixing strange character that is contributing to broken build
@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Aug 31, 2018

Member

I have fixed one error with the strange character.

Member

TimLethbridge commented Aug 31, 2018

I have fixed one error with the strange character.

@ZainabAlShowely

This comment has been minimized.

Show comment
Hide comment
@ZainabAlShowely

ZainabAlShowely Aug 31, 2018

Contributor

I see, thank you! The character does not seem to be interpreted on my machine as tests seem to run correctly even after a first build.

Contributor

ZainabAlShowely commented Aug 31, 2018

I see, thank you! The character does not seem to be interpreted on my machine as tests seem to run correctly even after a first build.

@TimLethbridge

This comment has been minimized.

Show comment
Hide comment
@TimLethbridge

TimLethbridge Aug 31, 2018

Member

@ZainabAlShowely Good news! On my machine the commit I did fixed the problem. The tests now pass. So I imagine they will pass here too. No need to look at this further.

Member

TimLethbridge commented Aug 31, 2018

@ZainabAlShowely Good news! On my machine the commit I did fixed the problem. The tests now pass. So I imagine they will pass here too. No need to look at this further.

@TimLethbridge TimLethbridge merged commit 9a924c0 into master Aug 31, 2018

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@TimLethbridge TimLethbridge deleted the QueuedMethods_Fix branch Sep 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment