Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper delete of close bracket for mixset inside method #1694

Merged
merged 3 commits into from May 10, 2021

Conversation

gublan24
Copy link
Member

@gublan24 gublan24 commented May 10, 2021

The current implementaion to handle mixsets inside methods does not remove the proper closing bracket of a mixset when it is nested in a complicated method structure. The generated code from the provided test case (in current Umple version) will generate code containing:

//TAG_MIXSET_BEFORE_CLOSE
}  
// The above closing bracket should be removed as StateMachine is used.
//TAG_MIXSET_CLOSE

This PR improves handling mixsets inside method bodies by removing the proper close brackets.

@TimLethbridge TimLethbridge merged commit af374b4 into master May 10, 2021
@TimLethbridge TimLethbridge deleted the properDeleteOfCloseBracketForMixset branch May 11, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants