New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

594 using immutable key gnerates invalid java code #655

Merged
merged 3 commits into from Nov 26, 2015

Conversation

Projects
None yet
2 participants
@toulayha
Contributor

toulayha commented Nov 26, 2015

  • Updated equals.jet file to check if key is mutable or lazy before using canSetK variable in the hash method.
  • Updated corresponding java files (JavaClassGenerator.java) under src-gen-umple/compiler and under UmpleToJava/compiler
  • Update existing test (EqualsTest.java) by updating expected output in the AlreadyImmutable() method; i.e. updated the java/EqualsTest_AlreadyImmutable.java.txt file
  • Added changes to templates that resulted from propagating the changes to all UmpleTo* files using ant -Dmyenv=local -f build.codegen.xml
  • Closes #594

TimLethbridge added a commit that referenced this pull request Nov 26, 2015

Merge pull request #655 from umple/594-immutableKey
594 using immutable key gnerates invalid java code

@TimLethbridge TimLethbridge merged commit 2a2ab04 into master Nov 26, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Nava2 Nava2 deleted the 594-immutableKey branch Dec 4, 2015

@Nava2 Nava2 restored the 594-immutableKey branch Dec 4, 2015

@Nava2 Nava2 deleted the 594-immutableKey branch Dec 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment