Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests #1464

Merged
merged 1 commit into from Sep 10, 2022
Merged

e2e tests #1464

merged 1 commit into from Sep 10, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Aug 23, 2022

  • adds playwright as testing framework
  • adds a test with comment posting as dev user

@codecov
Copy link

codecov bot commented Aug 23, 2022

Codecov Report

Merging #1464 (8d980b3) into master (499302c) will increase coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 8d980b3 differs from pull request most recent head 25b03a5. Consider uploading reports for the commit 25b03a5 to get more accurate results

@@            Coverage Diff             @@
##           master    #1464      +/-   ##
==========================================
+ Coverage   58.12%   58.14%   +0.01%     
==========================================
  Files         131      131              
  Lines        2909     2910       +1     
  Branches      743      743              
==========================================
+ Hits         1691     1692       +1     
  Misses       1214     1214              
  Partials        4        4              
Impacted Files Coverage Δ
frontend/apps/remark42/app/utils/post-message.ts 50.00% <50.00%> (ø)
...end/apps/remark42/app/components/comment/styles.ts 100.00% <0.00%> (ø)
...d/apps/remark42/app/components/comment/comment.tsx 62.38% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.39 KB (-0.02% 🔽)
public/remark.css 8.2 KB (0%)
public/last-comments.mjs 35.53 KB (-0.02% 🔽)
public/last-comments.css 3.79 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@akellbl4
Copy link
Collaborator Author

@akellbl4 akellbl4 marked this pull request as ready for review August 24, 2022 02:58
@akellbl4 akellbl4 requested a review from umputun as a code owner August 24, 2022 02:59
@akellbl4 akellbl4 requested review from paskal and Mavrin August 24, 2022 17:09
Mavrin
Mavrin previously approved these changes Aug 24, 2022
Copy link
Sponsor Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please tidy up the commit history. Twenty-eight commits, including merge ones, is too much.

Also, I expect something about e2e testing to be mentioned in the frontend Readme file.

compose-e2e-test.yml Outdated Show resolved Hide resolved
compose-e2e-test.yml Outdated Show resolved Hide resolved
compose-e2e-test.yml Outdated Show resolved Hide resolved
@paskal paskal requested a review from Mavrin August 30, 2022 23:22
@paskal paskal merged commit 0f7ac51 into master Sep 10, 2022
@paskal paskal deleted the e2e branch September 10, 2022 09:00
@paskal paskal added this to the v1.10.2 milestone Sep 10, 2022
@paskal paskal mentioned this pull request Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants