Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go modules #683

Merged
merged 1 commit into from Apr 13, 2020
Merged

Bump go modules #683

merged 1 commit into from Apr 13, 2020

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Apr 13, 2020

Without the latest versions of modules, I can't be sure that data race I'm chasing is not caused by some already-fixed problem in third-party library. To prevent stepping on potentially known problems in dependencies I suggest updating them.

This change removes almost 100 lines from go.sum which looks positive to me.

@paskal paskal added the backend label Apr 13, 2020
@paskal paskal requested a review from umputun April 13, 2020 13:07
@github-actions
Copy link

Pull Request Test Coverage Report for Build a8bd25e5c-PR-683

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.379%

Totals Coverage Status
Change from base Build a15acaf29: 0.0%
Covered Lines: 5137
Relevant Lines: 6161

💛 - Coveralls

@umputun umputun merged commit d6c7e15 into master Apr 13, 2020
@umputun umputun deleted the bump_modules branch April 13, 2020 17:03
@umputun umputun added this to the v1.6 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants