Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitedKingdom support with England #14

Closed

Conversation

domino91
Copy link

No description provided.

@pich
Copy link

pich commented May 24, 2023

Great job🚀

@tbuczen
Copy link

tbuczen commented May 25, 2023

+1

@pich
Copy link

pich commented May 25, 2023

@umulmrum Could you review this PR, merge and tag the new release?

@umulmrum
Copy link
Owner

Thank you very much for your PR and a thousand sorries for the long delay.

I created a new PR for the United Kingdom: #22
In this PR, I did a few things differently:

  • Tried to dig through the many holiday rules and one-off holidays of the UK in the past few decades (this lib aims to be accurate for the time after WW2), and added most of them (omitted Scottish regional holidays as well as islands, just as you did); added loads of tests for different years because of that.
  • Kept (Republic of) Ireland and UK separately as they are different countries.
  • Didn't implement England explicitly, as it appears to have the same holidays as the UK as a whole. Note that you can reference England with both the GB and GB-ENG ISO codes even if the latter isn't defined explicitly - the lib falls back to the higher level GB automatically.

As your PR has been lying around for a year, I didn't want to bother you with rework wishes - in any case, thank you for the contribution and the inspiration! If you find mistakes in the new implementation, I'm happy to read issues and/or further PRs.

@umulmrum umulmrum closed this May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants