Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize image files #149

Merged
merged 1 commit into from Jul 10, 2018

Conversation

@ykzts
Copy link
Contributor

commented Jul 8, 2018

Resolve #25

@unasuke

This comment has been minimized.

Copy link
Owner

commented Jul 9, 2018

@ykzts Thank you!

But I want to display small image in the article as a link that clicks to open original size image. So I want to keep original image.

The solution that I think, create middleman plugins...

@ykzts

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2018

In this Pull Request, only the file size has changed. Only compression algorithm optimization and unnecessary metadata deletion are done. I don't think it is necessary to leave the original image.

Also, since the speed of pngcrush and mozjpeg is slow, I think that should not be done with middleman's plugin.

@unasuke

This comment has been minimized.

Copy link
Owner

commented Jul 10, 2018

only the file size has changed

Ah, I understood it. It's good. Thank youl ❤️

@unasuke unasuke merged commit 9a243b6 into unasuke:master Jul 10, 2018
1 of 2 checks passed
1 of 2 checks passed
ci/circleci Your tests failed on CircleCI
Details
deploy/netlify Deploy preview ready!
Details
@ykzts ykzts deleted the ykzts:optimize branch Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.