Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different ways of setting datastore secrets #52

Closed
containerpope opened this issue Dec 26, 2019 · 3 comments
Closed

Allow different ways of setting datastore secrets #52

containerpope opened this issue Dec 26, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@containerpope
Copy link
Collaborator

Description

At the moment secrets are written in plain text into the datastore config yaml. This leads to problems in deployment, because the config should then be deployed as k8s secret for example because it contains sensitive data.

Proposals:

Separate option to provide files containing the secret information. These files could then be mounted as secrets into the pod.

@containerpope containerpope added the enhancement New feature or request label Dec 26, 2019
@containerpope
Copy link
Collaborator Author

@dcseifert what do you think ?

@dcseifert
Copy link
Contributor

dcseifert commented Dec 30, 2019

@mkjoerg With my latest commit for this issue, the datastore.yml-file can be expanded via environment variables. Therefore Secrets could be injected via mounting a k8s secret as environment variable

Does that also satisfy our needs, or is additional externalization into a file needed?

@dcseifert
Copy link
Contributor

Closing this issue after a discussion with #56 as optional further enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants