Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not loading since 20190406 #1207

Closed
lennyg1 opened this issue Apr 10, 2019 · 11 comments

Comments

Projects
None yet
3 participants
@lennyg1
Copy link

commented Apr 10, 2019

Since 20190406 the search page in FitNesse doesn't open for me. I'm getting the following error:

GET http://localhost:8000/FrontPage?search net::ERR_INVALID_CHUNKED_ENCODING 200 (OK)

Both in latest Chrome (73.0.3683.103) and IE11 the search page doesn't open. The search page does however open in Firefox 66.0.2.

20190224 works in both Firefox, IE11 and Chrome. I'm using Windows 8.1.

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

@tcnh, any thoughts?

@tcnh

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

I think tryingto fix #1187 has opened up pandora's box of browser mayhem. I cannot reproduce the described issue in any browser using W10 or the linux versions I have available.

I'd opt to reverse to before that fix and accept broken pipe warnings in debian 8/FF

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Apr 10, 2019

@lennyg1 is you Windows 8.1 machine configured to use a proxy, or do you have BitDefender (web protection)? I came across the following post on stack overflow that suggest that could cause problems: https://superuser.com/questions/893908/err-invalid-chunked-encoding-from-chrome

This would then be consistent with @tcnh not being able to reproduce the problem, as I assume his box had neither proxy nor BitDefender.

@lennyg1

This comment has been minimized.

Copy link
Author

commented Apr 10, 2019

No proxy, using localhost (with -lh switch). No bitdefender or other software that interferes with the connection present. Probably not very relevant, but using JDK8.

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

I can reproduce the problem on MacOS, using Chrome 73.0.3683.103 (64-bit) and Safari 12.1 (14607.1.40.1.4).

When I open http://localhost:9090/?responder=search&searchString=browser&searchScope=root&searchType=Search+Content

Both show the page correctly, but when I look with their development tools I see the reported error in Chrome's JavaScript console, and Safari's reports: Failed to load resource: cannot parse response

Firefox 64.0 and 66.0.3 do not report any problems.

@lennyg1

This comment has been minimized.

Copy link
Author

commented Apr 12, 2019

That's exactly the same behavior as in Win8.1 with Chrome/IE11. The page loads but with error. When opening http://localhost:9090/?responder=search the page doesn't load at all.

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Apr 13, 2019

Maybe reverting back to the original state before #1188 (also reverting #1204) is the best way forward.

Reading up on chunked encoding I get the impression that the change of #1204 was not correct: The closing chunk should be sent before the trailer. If we want to send trailing headers, we should not send a closing chunk after the headers. I'll try to address this today in a time box....

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Apr 13, 2019

I believe I fixed the errors, but I'm not sure about Debian. But both Windows 10 and macOS seem to work now (normal tests and search).

@tcnh can you check Debian for #1208 ?

@lennyg1

This comment has been minimized.

Copy link
Author

commented Apr 15, 2019

Tried changes from #1208 for IE11/Win8.1 and Chrome/Win8.1. Search loads again properly. No console errors in Chrome either. Testruns and the likes work for me as well.

@tcnh

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

@tcnh can you check Debian for #1208 ?

Checked. I see no exceptions in Debian 8 using FF ESR.

@fhoeben

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

Fixed in 20190416

@fhoeben fhoeben closed this Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.