Skip to content
This repository

Renaming with "all references" causes variable evaluation on other pages #15

Closed
ggramlich opened this Issue · 2 comments

2 participants

Gregor Gramlich Mike Stockdale
Gregor Gramlich
Collaborator

When renaming a page with the "Find all references to this page and change them accordingly (May take several minutes)" option on the Refactor page checked, it causes other pages to have some variables evaluated.

I renamed a page in the SuiteAcceptanceTests and it changed e.g. in
FitNesseRoot/FitNesse/SuiteAcceptanceTests/SuiteVirtualWikiTests/TestAliasLinkToNonExistentSubPage/content.txt

-|VirtualPage|!contents |VirtualWiki=http://localhost:${FITNESSE_PORT}/FitNesse.SuiteAcceptanceTests.AcceptanceTestPage|true |
+|VirtualPage|!contents |VirtualWiki=http://localhost:${FITNESSE_PORT8070/FitNesse.SuiteAcceptanceTests.AcceptanceTestPage|true |

Thus it must have evaluated the ${FITNESSE_PORT} variable and somehow put the value in place of the closing braces.

It even caused undefined variable to be evaluated, like in
FitNesseRoot/FitNesse/UserGuide/QuickReferenceGuide/content.txt

-|Alias Link |${CODE} '''[['''${TEXT}''']['''${AnyPagePATH}''']]''' ${CODEend}| |
+|Alias Link |${CODE} '''[['''${TEXT}''']['''${AnyPagePATHundefined variable: AnyPagePATH''']]''' ${CODEend}|

Interestingly here ${TEXT} (like many other variables on the page) was left untouched.

I am using the latest version from jediwhale's repository.

Gregor

Mike Stockdale
Collaborator

Has this been fixed? I tried to recreate it with the latest build and I can't.

Gregor Gramlich
Collaborator

You answered on my email, that it has been fixed. 2011-March-03, this is probably commit jediwhale@cd70621

Gregor Gramlich ggramlich closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.