Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Renaming with "all references" causes variable evaluation on other pages #15

Closed
ggramlich opened this Issue Mar 2, 2011 · 2 comments

Comments

Projects
None yet
2 participants
Collaborator

ggramlich commented Mar 2, 2011

When renaming a page with the "Find all references to this page and change them accordingly (May take several minutes)" option on the Refactor page checked, it causes other pages to have some variables evaluated.

I renamed a page in the SuiteAcceptanceTests and it changed e.g. in
FitNesseRoot/FitNesse/SuiteAcceptanceTests/SuiteVirtualWikiTests/TestAliasLinkToNonExistentSubPage/content.txt

-|VirtualPage|!contents |VirtualWiki=http://localhost:${FITNESSE_PORT}/FitNesse.SuiteAcceptanceTests.AcceptanceTestPage|true |
+|VirtualPage|!contents |VirtualWiki=http://localhost:${FITNESSE_PORT8070/FitNesse.SuiteAcceptanceTests.AcceptanceTestPage|true |

Thus it must have evaluated the ${FITNESSE_PORT} variable and somehow put the value in place of the closing braces.

It even caused undefined variable to be evaluated, like in
FitNesseRoot/FitNesse/UserGuide/QuickReferenceGuide/content.txt

-|Alias Link |${CODE} '''[['''${TEXT}''']['''${AnyPagePATH}''']]''' ${CODEend}| |
+|Alias Link |${CODE} '''[['''${TEXT}''']['''${AnyPagePATHundefined variable: AnyPagePATH''']]''' ${CODEend}|

Interestingly here ${TEXT} (like many other variables on the page) was left untouched.

I am using the latest version from jediwhale's repository.

Gregor

Collaborator

jediwhale commented May 4, 2012

Has this been fixed? I tried to recreate it with the latest build and I can't.

Collaborator

ggramlich commented May 5, 2012

You answered on my email, that it has been fixed. 2011-March-03, this is probably commit jediwhale/fitnesse@cd70621

@ggramlich ggramlich closed this May 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment