Skip to content

Loading…

Time values in CommandRunner class' waitForDeathOf method not configurable. #254

Closed
patStar opened this Issue · 4 comments

4 participants

@patStar

We've encountered some problems with our tests due to the hard coded time values in the method waitForDeathOf in the CommandRunner class (line 89 and 91). Making these values configurable would solve these problems.

Thank you!

Pat

@mgaertne
Collaborator
@patStar

We're using Fitnesse for our integration tests and it seems that for some processes (not always the same), it takes up to 4 seconds to die. The main problem may be our hardware or the load on the system but nevertheless it would be nice if we could tell fitnesse to wait some seconds longer.

Here some of the output

Starting Test System: slim using fitnesse.slim.SlimService.
. 14:12:11 R:9 W:0 I:0 E:0 XXX (XXX) 42,384 seconds
java.lang.IllegalThreadStateException: process hasn't exited
at java.lang.UNIXProcess.exitValue(UNIXProcess.java:217)
at fitnesse.testsystems.CommandRunner.join(CommandRunner.java:85)
Could not detect death of command line test runner.
at fitnesse.testsystems.slim.SlimTestSystem.bye(SlimTestSystem.java:114)
at fitnesse.responders.run.MultipleTestsRunner.startTestSystemAndExecutePages(MultipleTestsRunner.java:123)
at fitnesse.responders.run.MultipleTestsRunner.internalExecuteTestPages(MultipleTestsRunner.java:92)
at fitnesse.responders.run.MultipleTestsRunner.executeTestPages(MultipleTestsRunner.java:65)

@amolenaar
Collaborator

Can you perform a specific shutdown of the SUT through a fixture call?

@Kosta-Github

We experience the same issue. A specific shutdown fixture does not work for us, since we do some more cleanups after main() (from within our C++ code base, e.g., cleaning up some rather expensive singletons). So a configurable waitForDeath-value would definitely help!

Or maybe the test system itself could specify an approx. number of seconds to be expected to die as response to the "BYE" command. :-)

@amolenaar amolenaar added this to the Next release milestone
@amolenaar amolenaar closed this in 4c2d466
@antoine-aumjaud antoine-aumjaud pushed a commit to antoine-aumjaud/fitnesse that referenced this issue
@amolenaar amolenaar Add configurable timeout for start up and shutdown of SLIM system und…
…er test.

Fixes #254.
1cdbfc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.