Nested Symbolic Links don't work #261

Closed
konstantinvlasenko opened this Issue May 18, 2013 · 6 comments

Projects

None yet

3 participants

@konstantinvlasenko
Contributor

symboliclinksissue

@konstantinvlasenko
Contributor

My idea right now is to modify the page path for children in the fitnesse.wiki.BaseWikiPage.getChildren() method if the following condition is TRUE:

if (symLinksProperty != null) {
  if(this instanceof SymbolicPage) {
    System.out.println("SymbolicPage has links");
  }
}

But it looks like ad hoc solution.

@woodybrood
Collaborator

What is your goal? What problem are you trying to solve?

Daniel Woodward
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)

On Friday, May 17, 2013 at 8:38 PM, konstantinvlasenko wrote:

My idea right now is to modify the page path in the fitnesse.wiki.BaseWikiPage.getChildren() method if the following condition is TRUE:
if (symLinksProperty != null) { if(this instanceof SymbolicPage) { System.out.println("SymbolicPage has links"); } }
But it looks like ad hoc solution.


Reply to this email directly or view it on GitHub (#261 (comment)).

@konstantinvlasenko
Contributor

My SUT can be run in 2 different environments with 2 different modes in each. So 4 different cases.
So I have a test which can be parameterized by several defined (!define ...).
Each Suite have the unique set of defines. So I want to have only one test and link it to all of them.
And I want Target 2 links only highlevel suites from Target 1. So I don't want to add links to Target 2 each time I wrote a new test. Make sense?

@woodybrood
Collaborator

I can't speak for everyone, but I would think we need a solution that prevents circular references, as that would bad. So, if you want to start building this, I would recommend forking FitNesse and adding unit tests that ensure that circular references are not followed. In the mean time, you could use your forked version while you ensure that you've done enough testing.

Just a thought though, wouldn't something like below work the same for you?
layout

@konstantinvlasenko
Contributor

I believe your solution will work in general. But I want to have some symlinks inside the Test Suite as well. And actually I do have them :)
You absolutely right about circular references. We should keep it in mind and have sufficient amount of tests.
And YES. I do have my fitnesse fork;) I did my first contribution to Fitnesse 4 years ago.

@amolenaar amolenaar added this to the Next release milestone May 18, 2014
@amolenaar
Collaborator

Fixed by #454.

@amolenaar amolenaar closed this May 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment