file leak: socket not closed #341

Closed
denisko opened this Issue Oct 1, 2013 · 5 comments

3 participants

@denisko

Steps to reproduce:
1: Start fitnesse
2: Do this several times for an existing testcase
curl -s "http://localhost:8000/FrontPage.MyTest?test" >/dev/null
3: Afterwards check the open files of fitnesse, e.g.:
lsof -P -p
Several open sockets will show in state CLOSE_WAIT

My platform: Mac OSX latest version, java7, latest version of fitnesse right from master branch, using slim.

This is probably just a finally {} missing with a close on the socket. If you can give me a hint to the classname where this might be, I will gladly send you a pull request once it is solved.

@ggramlich
Collaborator

Is FrontPage.MyTest a Slim Test or a Fit Test?

@denisko

This is FrontPage.MyTest:

!define TEST_SYSTEM {slim} 

|comment|                  |
|this   |is|a|comment|table|

After running this several times, lsof shows a long list of open sockets in state CLOSE_WAIT

@amolenaar
Collaborator

Hmm... You can have a look at SlimTestSystem and the SlimClient it's using underneath.

@denisko

Yep, this solves this issue. Issue can be closed.

@amolenaar
Collaborator

fixed by #342.

@amolenaar amolenaar closed this Oct 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment