New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!contents -p not showing symbolic link attribute, as documented #541

Closed
ALuckyGuy opened this Issue Oct 17, 2014 · 5 comments

Comments

Projects
None yet
3 participants
@ALuckyGuy

ALuckyGuy commented Oct 17, 2014

Running both an August 24th and October 6th build, the symbolic link attribute, default '>', is never displayed when a !contents -p option is used. Not sure if it ever worked, and checking the Acceptance tests, I can't see that there are any tests to verify the behavior.

Additionally, I don't see tests for verifying that the global variable PROPERTY_CHARACTERS works, and it doesn't seem to either.

@mwarhaftig

This comment has been minimized.

Contributor

mwarhaftig commented Nov 3, 2014

Hi ALuckyGuy, I recreated the behavior you are seeing with HEAD - let me try to track down the cause.

mwarhaftig added a commit to mwarhaftig/fitnesse that referenced this issue Nov 9, 2014

@mwarhaftig

This comment has been minimized.

Contributor

mwarhaftig commented Nov 9, 2014

Above pull request fixes both of the !contents issues you identified: missing symbolic link property suffixes & ignored PROPERTY_CHARACTERS variables.

@ALuckyGuy

This comment has been minimized.

ALuckyGuy commented Nov 9, 2014

That's awesome... thank you!

amolenaar added a commit that referenced this issue Nov 11, 2014

Merge pull request #552 from mwarhaftig/master
Issue #541 - Added SymLinks & PROPERTY_CHARACTERS variable to !contents.
@ALuckyGuy

This comment has been minimized.

ALuckyGuy commented Nov 18, 2014

Seems to be working. Thanks again.

@amolenaar

This comment has been minimized.

Collaborator

amolenaar commented Dec 27, 2015

Closing issue. A fix has been merged a while back already.

@amolenaar amolenaar closed this Dec 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment