New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML content is always included in XML result file #771

Closed
ufroehling opened this Issue Jul 21, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@ufroehling

ufroehling commented Jul 21, 2015

In the past it was optional to have the HTML content tags included in the XML results to keep them compact. See http://fitnesse.org/FitNesse.FullReferenceGuide.UserGuide.AdministeringFitNesse.RestfulServices.RestfulSuiteXmlFormat
And we have the REST parameter &includeHTML for the ?suite command to include them on demand.
But at least in our currently used version v20150424 the HTML content tag is always included which blows up the result files. See the comment for the includeHtml parameter: "If format=xml then this will cause the XML to contain a 'content' tag that holds the HTML of the tested page. Beware, this can lead to OutOfMemory errors for large suites."
My colleagues and I want the old behaviour back

Can be reproduced with
http://localhost:8090/FitNesse.SuiteAcceptanceTests.SuiteSlimTests.QueryTableSuite?suite&format=xml

mwarhaftig added a commit to mwarhaftig/fitnesse that referenced this issue Jul 26, 2015

@mwarhaftig

This comment has been minimized.

Show comment
Hide comment
@mwarhaftig

mwarhaftig Jul 26, 2015

Contributor

Hi ufroehling, looks like you found a bug - the behavior you want should have not been removed. Details on the cause and fix are on the associated merge request.

Contributor

mwarhaftig commented Jul 26, 2015

Hi ufroehling, looks like you found a bug - the behavior you want should have not been removed. Details on the cause and fix are on the associated merge request.

amolenaar added a commit that referenced this issue Jul 27, 2015

Merge pull request #773 from mwarhaftig/issue771
Issue #771 - Default includeHtml suite xml results flag to false.

@amolenaar amolenaar added this to the Next release milestone Jul 27, 2015

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar Jul 27, 2015

Collaborator

Merged :)

Collaborator

amolenaar commented Jul 27, 2015

Merged :)

@amolenaar amolenaar closed this Jul 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment