New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkupHashTable produce error when need to be mapped in Map<String, String> in newest version of fitnesse #892

Open
sasastarcevic opened this Issue Mar 18, 2016 · 6 comments

Comments

Projects
None yet
4 participants
@sasastarcevic

sasastarcevic commented Mar 18, 2016

Hi All,

Right now we use fitnesse version: 20140901 in our project and with this version we can use step like:
|and |set customer capabilities !{CAP2:100000, CAP2:1}|

In java we use:
@DomainStep("(?si)set customer capabilities (.+)") public void setCustomerCapabilities(Map<String, String> capability) {

But from fitnesse version: 20150424 up to newest 20151230 (http://www.fitnesse.org/FitNesseDownload of course we have checked release notes, but we haven't found solution), same step will fail, with error:
Caused by: java.lang.IllegalArgumentException: argument type mismatch

Of course we can bypass this (with parsing and creating object), but do we have some better solution?

Many thanks,
Sasa

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar Apr 25, 2016

Collaborator

Hi,

Let me check on this.

Collaborator

amolenaar commented Apr 25, 2016

Hi,

Let me check on this.

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar Apr 25, 2016

Collaborator

What does the @DomainStep annotation do? It is not part of FitNesse.

Collaborator

amolenaar commented Apr 25, 2016

What does the @DomainStep annotation do? It is not part of FitNesse.

@sasastarcevic

This comment has been minimized.

Show comment
Hide comment
@sasastarcevic

sasastarcevic Apr 26, 2016

Hi,

We use @DomainStep annotation while creating wiki steps in Java classes, so that we can call java methods from fitnesse wiki pages.

It is used in combination with annotation: @DomainSteps

For example, we have class: CapabilitySteps and we need to have annotatio like:

@DomainSteps
public class CapabilitySteps {
...
and in this class we have method:

@DomainStep("(?si)set customer capabilities (.+)")
public void setCustomerCapabilities(Map <String, String> capability) {
.....

And when we have class like this, then we can call this method from fitnesse wiki page, like:
|then |set customer capabilities !{CAP_1:100000, CAP_2:0} |
So this is not working with new version of fitnesse.

Imports for DomainStep:
import org.givwenzen.annotations.DomainStep;
import org.givwenzen.annotations.DomainSteps;

Sorry for late response.
BR,
Sasa

sasastarcevic commented Apr 26, 2016

Hi,

We use @DomainStep annotation while creating wiki steps in Java classes, so that we can call java methods from fitnesse wiki pages.

It is used in combination with annotation: @DomainSteps

For example, we have class: CapabilitySteps and we need to have annotatio like:

@DomainSteps
public class CapabilitySteps {
...
and in this class we have method:

@DomainStep("(?si)set customer capabilities (.+)")
public void setCustomerCapabilities(Map <String, String> capability) {
.....

And when we have class like this, then we can call this method from fitnesse wiki page, like:
|then |set customer capabilities !{CAP_1:100000, CAP_2:0} |
So this is not working with new version of fitnesse.

Imports for DomainStep:
import org.givwenzen.annotations.DomainStep;
import org.givwenzen.annotations.DomainSteps;

Sorry for late response.
BR,
Sasa

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar May 19, 2016

Collaborator

Is this a problem in the DomainStep maybe? I added some tests in FitNesse and it seems to work fine.

Collaborator

amolenaar commented May 19, 2016

Is this a problem in the DomainStep maybe? I added some tests in FitNesse and it seems to work fine.

@s-ivanova

This comment has been minimized.

Show comment
Hide comment
@s-ivanova

s-ivanova Dec 27, 2016

We use givwenzen - plugin to Fitnesse. Everything was working fine with 20140901 version. We tried the newest version 20161106 and the issue still persist:
Caused by: java.lang.IllegalArgumentException: argument type mismatch

This is visible in the log:
WARNING: An error occured while fulfilling user request [fitnesse.http.HttpException: The request string is malformed and can not be parsed]
java.util.concurrent.ExecutionException: fitnesse.http.HttpException: The request string is malformed and can not be parsed
at java.util.concurrent.FutureTask.report(Unknown Source)
at java.util.concurrent.FutureTask.get(Unknown Source)
at fitnesse.FitNesseExpediter.makeResponse(FitNesseExpediter.java:105)
at fitnesse.FitNesseExpediter.run(FitNesseExpediter.java:58)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: fitnesse.http.HttpException: The request string is malformed and can not be parsed
at fitnesse.http.Request.checkRequestLine(Request.java:159)
at fitnesse.http.Request.readAndParseRequestLine(Request.java:73)
at fitnesse.http.Request.parse(Request.java:61)
at fitnesse.FitNesseExpediter$1.call(FitNesseExpediter.java:102)
at fitnesse.FitNesseExpediter$1.call(FitNesseExpediter.java:99)

I saw that there are changes in FitNesseExpediter.java and Request.java
@amolenaar , Could you please check and advice?

s-ivanova commented Dec 27, 2016

We use givwenzen - plugin to Fitnesse. Everything was working fine with 20140901 version. We tried the newest version 20161106 and the issue still persist:
Caused by: java.lang.IllegalArgumentException: argument type mismatch

This is visible in the log:
WARNING: An error occured while fulfilling user request [fitnesse.http.HttpException: The request string is malformed and can not be parsed]
java.util.concurrent.ExecutionException: fitnesse.http.HttpException: The request string is malformed and can not be parsed
at java.util.concurrent.FutureTask.report(Unknown Source)
at java.util.concurrent.FutureTask.get(Unknown Source)
at fitnesse.FitNesseExpediter.makeResponse(FitNesseExpediter.java:105)
at fitnesse.FitNesseExpediter.run(FitNesseExpediter.java:58)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: fitnesse.http.HttpException: The request string is malformed and can not be parsed
at fitnesse.http.Request.checkRequestLine(Request.java:159)
at fitnesse.http.Request.readAndParseRequestLine(Request.java:73)
at fitnesse.http.Request.parse(Request.java:61)
at fitnesse.FitNesseExpediter$1.call(FitNesseExpediter.java:102)
at fitnesse.FitNesseExpediter$1.call(FitNesseExpediter.java:99)

I saw that there are changes in FitNesseExpediter.java and Request.java
@amolenaar , Could you please check and advice?

@janakijayasree

This comment has been minimized.

Show comment
Hide comment
@janakijayasree

janakijayasree Mar 21, 2017

hi i am using fitnesse-standalone latest ersion jar when i starting fitnesse on port:xxxx i am getting this error after taking long time time.even my test results are showing nothing.Please help me in this how to solve issue in connecting to port
An error occured while fulfilling user request [fitnesse.http.HttpException: The request string is malformed and can not be parsed]
java.util.concurrent.ExecutionException: fitnesse.http.HttpException: The request string is malformed and can not be parsed
at java.util.concurrent.FutureTask.report(Unknown Source)
at java.util.concurrent.FutureTask.get(Unknown Source)
at fitnesse.FitNesseExpediter.makeResponse(FitNesseExpediter.java:105)
at fitnesse.FitNesseExpediter.run(FitNesseExpediter.java:58)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown

janakijayasree commented Mar 21, 2017

hi i am using fitnesse-standalone latest ersion jar when i starting fitnesse on port:xxxx i am getting this error after taking long time time.even my test results are showing nothing.Please help me in this how to solve issue in connecting to port
An error occured while fulfilling user request [fitnesse.http.HttpException: The request string is malformed and can not be parsed]
java.util.concurrent.ExecutionException: fitnesse.http.HttpException: The request string is malformed and can not be parsed
at java.util.concurrent.FutureTask.report(Unknown Source)
at java.util.concurrent.FutureTask.get(Unknown Source)
at fitnesse.FitNesseExpediter.makeResponse(FitNesseExpediter.java:105)
at fitnesse.FitNesseExpediter.run(FitNesseExpediter.java:58)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment