Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to add content to non-existing elements during test run #1203

Merged
merged 3 commits into from Apr 6, 2019

Conversation

Projects
None yet
1 participant
@fhoeben
Copy link
Collaborator

commented Apr 3, 2019

Fix #1199, by having SuiteHtmlFormatter only update the content of the test-summaries element of the test result page if that element is actually added by SuiteResponder.

The fix is not 100% guaranteed as the SuiteResponder's html page is rendered by the template that could be altered. The SuiteHtmlFormatter is now given the same boolean which is used in the bundled template (testPage.vm) to decide whether or not to add the test-summaries element.

@fhoeben fhoeben merged commit 4c5d347 into unclebob:master Apr 6, 2019

@fhoeben fhoeben deleted the fitnesse:bugix/jsErrorsSinglePage branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.