HTML fixes for JavaFormatter #165

Merged
merged 4 commits into from Feb 28, 2013

Conversation

Projects
None yet
3 participants
Contributor

awulder commented Dec 21, 2012

  • Fixed JavaScript errors by adding jQuery
  • Updated HTML (added header and article tags) because some bindings defined in fitnesse.js failed. The collapsible functionality on the result page will work again.

Arjan Wulder added some commits Dec 21, 2012

Arjan Wulder HTML fixes for JavaFormatter
- Fixed JavaScript errors by adding jQuery
- Updated HTML (added header and article tags) because some bindings
defined in fitnesse.js failed. The collapsible on the result page will
work again.
19c144f
Arjan Wulder HTML fixes for JavaFormatter
Forget to commit failing Unit test
9e12f72
Arjan Wulder Moved static files to folders
The arrows didn't show because the relative paths were incorrect. By
moving the static files to folders it works as expected.
7382620
Contributor

benilovj commented Dec 23, 2012

Hi,

Because your editor reformatted the code, it's very hard to see from the diff what's changed. Also, I believe that the standard for this project is a 2-space indent. Would it be possible to update your changes with that in mind?

thanks

Arjan Wulder 2-space indent fix
Now using 2-space indent instead of 4-spaces
7123c94
Contributor

benilovj commented Dec 23, 2012

thats much better, thanks!

Contributor

awulder commented Dec 23, 2012

I had the wong coding style template selected

Collaborator

amolenaar commented Dec 29, 2012

I would have preferred if Velocity had been used to render the page.

Contributor

awulder commented Dec 29, 2012

@amolenaar I think it's a good idea to use Velocity. I will refactor the JavaFormatter. Consider this as a quick fix for the bug.

amolenaar merged commit e442778 into unclebob:master Feb 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment