Comment columns for slim decision and query tables #401

Merged
merged 3 commits into from Feb 11, 2014

Conversation

Projects
None yet
2 participants
Contributor

mbarchfe commented Feb 5, 2014

This enhancement has been discussed before on pivotal as id 3562479 and topic "ignored columns"
It was rated as nice, but not necessary. Comment columns are marked by starting the header with #. This is in conformance to comments used within slim script tables.

Unfortunately, I was not aware of the comment cells mentioned there when I started to implement this feature. Nonetheless, comment columns are more useful than comment cells in my current use case, since I generate wiki pages from Excel sheets.

If there were not much more effort to implement the feature than to pull in the two commits here I would be happy to see this feature in fitness in the future.

Thanks
Markus

commentcolumnquerytable

Collaborator

amolenaar commented Feb 7, 2014

If you can update the SliM tables documentation, that would be awesome.

amolenaar added this to the Next release milestone Feb 7, 2014

Contributor

mbarchfe commented Feb 9, 2014

I have updated the wiki documentation in the commented column branch of my fork.

However, what seems odd to me is that fitness.slim.test.ShouldIBuyMilk was removed in November with commit 86acfa3. The wiki page FitNesseRoot/FitNesse/UserGuide/SliM/DecisionTable/content.txt did not work anymore because of that missing class. I have therefore re-added it.

amolenaar merged commit 52c0643 into unclebob:master Feb 11, 2014

Collaborator

amolenaar commented Feb 11, 2014

I think I was I bit rigorous in cleaning up some apparently unused stuff.

It's in. Thanks!

mbarchfe deleted the mbarchfe:commentedcolumns branch Feb 13, 2014

Contributor

mbarchfe commented Feb 13, 2014

Thanks for adding the feature. One question concerning the broken user guide. In order to avoid similar problems in the future: Could a check of the status quo of the tests within the user guide be a part of the acceptance test suite?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment