Skip to content

Loading…

Java 7 returns localized error messages which causes two tests to fail... #412

Merged
merged 1 commit into from

2 participants

@NicoleRauch

...on non-English machines (because the tests explicitly check parts of the error message). Adding the locale to the java command invocation fixes this.

@NicoleRauch NicoleRauch Java 7 returns localized error messages which causes two tests to fai…
…l (because they explicitly check parts of the error message). Adding the locale to the java command invocation fixes this.
3c67883
@amolenaar amolenaar merged commit 3c67883 into unclebob:master
@amolenaar
Collaborator

Thanks, Nicole.

@amolenaar amolenaar added this to the Next release milestone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 2, 2014
  1. @NicoleRauch

    Java 7 returns localized error messages which causes two tests to fai…

    NicoleRauch committed
    …l (because they explicitly check parts of the error message). Adding the locale to the java command invocation fixes this.
This page is out of date. Refresh to see the latest.
View
2 test/fitnesse/testsystems/CommandRunnerTest.java
@@ -22,7 +22,7 @@ public void testBasics() throws Exception {
@Test
public void testClassNotFound() throws Exception {
- CommandRunner runner = new CommandRunner("java BadClass", "", null);
+ CommandRunner runner = new CommandRunner("java -Duser.country=US -Duser.language=en BadClass", "", null);
runner.run();
assertHasRegexp("Error", runner.getError());
assertEquals("", runner.getOutput());
View
2 test/fitnesse/testsystems/fit/FitClientTest.java
@@ -72,7 +72,7 @@ private void doSimpleRun() throws Exception {
@Test
public void testStandardError() throws Exception {
- client = new CommandRunningFitClient(new CommandRunningFitClient.OutOfProcessCommandRunner("java blah", null));
+ client = new CommandRunningFitClient(new CommandRunningFitClient.OutOfProcessCommandRunner("java -Duser.country=US -Duser.language=en blah", null));
client.addFitClientListener(this);
client.start();
Thread.sleep(100);
Something went wrong with that request. Please try again.