Skip to content

/ fitnesse

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensible wiki pages #505

Merged
merged 36 commits into from Aug 17, 2014
Merged

Extensible wiki pages #505

merged 36 commits into from Aug 17, 2014

Conversation

@amolenaar
Copy link
Collaborator

@amolenaar amolenaar commented Aug 13, 2014

This pull request makes some serious changes to the way wiki pages work:

  • Custom WikiPageFactorys can be configured using the WikiPageFactories configuration setting
  • All child page creation goes via the factory.
  • PageData is no longer dependent on a WikiPage
  • WikiPage is now responsible for rendering content, PageData has become merely a container
  • WikiPages set their default properties themselves.
  • Added WikitextPage interface to facilitate in things like processing class paths
  • Clean up on WikiPage interface
  • TestPage is no longer a sub-interface of WikiPage
amolenaar added 30 commits Jul 1, 2014
@amolenaar
Make BaseWikiPage fields private.
ed6019d
@amolenaar
Move creation of ExternalSuitePages to a dedicated factory.
2b17fde
@amolenaar
Get FileSystemPage.getFileSystemPath() return java.io.File.
06c9c36
@amolenaar
Update WikiPageFactory.makePage(), allow for a parent, make rootPath …
0f73682 
…a File.
@amolenaar
Add WikiPage.getHtml(). Should replace PageData.getHtml().
fb16f12
@amolenaar
Replace getData().getHtml() train by just getHtml()
b7c9cf4 
Attempting to move getHtml() and code to WikiPage.
@amolenaar
Remove duplicate runtime exception.
49fdce6
@amolenaar
Get Html directly from TestPage.
8023f00
@amolenaar
Replace getData().getHtml() train by just getHtml() for TestPage
11b8e92 
Attempting to move getHtml() and code to WikiPage.
@amolenaar
Implement WikiPage.getVersion(versionName). Will replace getDataVersi…
145be3d 
…on().
@amolenaar
Replace invocations of getDataVersion() with getVersion().
e99c3e2
@amolenaar
Move PageData.getXrefPages to WikiPage. Make TestPage a subtype of Wi…
9f21c67 
…kiPage.

Needed the last change to make sure the page rendering does not distinguish between Wiki and Test pages
@amolenaar
Get ParsedPage from WikiPage via special interface.
70e3a5f
@amolenaar
Build ref pages and class path via WikitextPage interface.
ea25eaf
@amolenaar
Move getHeaderPage and getFooterPage out of the WikiPage interface, i…
3982657 
…nto WikiPageUtil.
@amolenaar
Let symbolicPage return a default (empty) parsed page.
aa3385b
@amolenaar
Remove WikiPage.readOnlyData(). Just use getData().
81ae07a
@amolenaar
Remove use of PageData.getWikiPage() from RecentChanges and SaveRecor…
d398c4b 
…der.
@amolenaar
Remove use of WikiPageDummy from application.
c5b0657
@amolenaar
Remove WikiPageDummy.setParent().
c3ba1d3
@amolenaar
Remove ReadOnlyPageData.getHtml().
a0b8000
@amolenaar
Remove wiki page reference from PageData.
971f217
@amolenaar
Add WikiPageFactories config option, allow for adding arbitrary page …
96b3cf8 
…types.
@amolenaar
Make PageCrawlerImpl constructor public.
7c195d5
@amolenaar
Update build scrips so local installations can be done.
b9bbb2e
@amolenaar
Small cleanup in FileSystemPageFactory.
77db806
@amolenaar
Make WikiPageFactory.makePage() consistent with support().
fc0a07b 
The page factory expects the path to the page, not to the parent of a page.
This allows for pages that use a name in FitNesse different from the one on fs.
@amolenaar
Fix snapshot deployment in build.
c4e6249
@amolenaar
User FITNESSE_ROOTPATH to determine root path for relative external p…
4c4d966 
…age references.
@amolenaar
Document WikiPage interface somewhat
68442ca
amolenaar added 6 commits Aug 7, 2014
@amolenaar
Save responder can deal with empty commit information
55e25a6
@amolenaar
Use FileSystemPage.path to determine where the content is.
a47a191 
Do not rely on parent pages for correct paths.
@amolenaar
Move render logic to BaseWikiPage so it can be shared between Filesys…
e36d703 
…temPage and SymbolicPage.
@amolenaar
Disconnect TestPage from WikiPage.
8c38bb0 
We're crossing subsystem borders here.
@amolenaar
Move setting page properties to the appropriate page types.
db9536a
@amolenaar
Merge branch 'master' into pagedata
316d988 
Conflicts:
	test/fitnesse/wiki/fs/FileSystemPageTest.java
@amolenaar amolenaar added this to the Next release milestone Aug 14, 2014
@amolenaar amolenaar merged commit 316d988 into unclebob:master Aug 17, 2014
@amolenaar amolenaar deleted the amolenaar:pagedata branch Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20140901
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
@amolenaar