New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible wiki pages #505

merged 36 commits into from Aug 17, 2014


None yet
1 participant

amolenaar commented Aug 13, 2014

This pull request makes some serious changes to the way wiki pages work:

  • Custom WikiPageFactorys can be configured using the WikiPageFactories configuration setting
  • All child page creation goes via the factory.
  • PageData is no longer dependent on a WikiPage
  • WikiPage is now responsible for rendering content, PageData has become merely a container
  • WikiPages set their default properties themselves.
  • Added WikitextPage interface to facilitate in things like processing class paths
  • Clean up on WikiPage interface
  • TestPage is no longer a sub-interface of WikiPage

amolenaar added some commits Jul 1, 2014

Replace getData().getHtml() train by just getHtml()
Attempting to move getHtml() and code to WikiPage.
Replace getData().getHtml() train by just getHtml() for TestPage
Attempting to move getHtml() and code to WikiPage.
Move PageData.getXrefPages to WikiPage. Make TestPage a subtype of Wi…

Needed the last change to make sure the page rendering does not distinguish between Wiki and Test pages
Make WikiPageFactory.makePage() consistent with support().
The page factory expects the path to the page, not to the parent of a page.
This allows for pages that use a name in FitNesse different from the one on fs.

@amolenaar amolenaar added this to the Next release milestone Aug 14, 2014

@amolenaar amolenaar merged commit 316d988 into unclebob:master Aug 17, 2014

@amolenaar amolenaar deleted the amolenaar:pagedata branch Sep 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment