/fitnesse

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensible wiki pages #505

Merged
merged 36 commits into from Aug 17, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
  20140901
1 participant
@amolenaar
@amolenaar
Collaborator

amolenaar commented Aug 13, 2014

This pull request makes some serious changes to the way wiki pages work:

  • Custom WikiPageFactorys can be configured using the WikiPageFactories configuration setting
  • All child page creation goes via the factory.
  • PageData is no longer dependent on a WikiPage
  • WikiPage is now responsible for rendering content, PageData has become merely a container
  • WikiPages set their default properties themselves.
  • Added WikitextPage interface to facilitate in things like processing class paths
  • Clean up on WikiPage interface
  • TestPage is no longer a sub-interface of WikiPage

amolenaar added some commits Jul 1, 2014

@amolenaar
Make BaseWikiPage fields private.
ed6019d
@amolenaar
Move creation of ExternalSuitePages to a dedicated factory.
2b17fde
@amolenaar
Get FileSystemPage.getFileSystemPath() return java.io.File.
06c9c36
@amolenaar
Update WikiPageFactory.makePage(), allow for a parent, make rootPath … 
…a File.
0f73682
@amolenaar
Add WikiPage.getHtml(). Should replace PageData.getHtml().
fb16f12
@amolenaar
Replace getData().getHtml() train by just getHtml() 
Attempting to move getHtml() and code to WikiPage.
b7c9cf4
@amolenaar
Remove duplicate runtime exception.
49fdce6
@amolenaar
Get Html directly from TestPage.
8023f00
@amolenaar
Replace getData().getHtml() train by just getHtml() for TestPage 
Attempting to move getHtml() and code to WikiPage.
11b8e92
@amolenaar
Implement WikiPage.getVersion(versionName). Will replace getDataVersi… 
…on().
145be3d
@amolenaar
Replace invocations of getDataVersion() with getVersion().
e99c3e2
@amolenaar
Move PageData.getXrefPages to WikiPage. Make TestPage a subtype of Wi… 
…kiPage.

Needed the last change to make sure the page rendering does not distinguish between Wiki and Test pages
9f21c67
@amolenaar
Get ParsedPage from WikiPage via special interface.
70e3a5f
@amolenaar
Build ref pages and class path via WikitextPage interface.
ea25eaf
@amolenaar
Move getHeaderPage and getFooterPage out of the WikiPage interface, i… 
…nto WikiPageUtil.
3982657
@amolenaar
Let symbolicPage return a default (empty) parsed page.
aa3385b
@amolenaar
Remove WikiPage.readOnlyData(). Just use getData().
81ae07a
@amolenaar
Remove use of PageData.getWikiPage() from RecentChanges and SaveRecor… 
…der.
d398c4b
@amolenaar
Remove use of WikiPageDummy from application.
c5b0657
@amolenaar
Remove WikiPageDummy.setParent().
c3ba1d3
@amolenaar
Remove ReadOnlyPageData.getHtml().
a0b8000
@amolenaar
Remove wiki page reference from PageData.
971f217
@amolenaar
Add WikiPageFactories config option, allow for adding arbitrary page … 
…types.
96b3cf8
@amolenaar
Make PageCrawlerImpl constructor public.
7c195d5
@amolenaar
Update build scrips so local installations can be done.
b9bbb2e
@amolenaar
Small cleanup in FileSystemPageFactory.
77db806
@amolenaar
Make WikiPageFactory.makePage() consistent with support(). 
The page factory expects the path to the page, not to the parent of a page.
This allows for pages that use a name in FitNesse different from the one on fs.
fc0a07b
@amolenaar
Fix snapshot deployment in build.
c4e6249
@amolenaar
User FITNESSE_ROOTPATH to determine root path for relative external p… 
…age references.
4c4d966
@amolenaar
Document WikiPage interface somewhat
68442ca

@amolenaar amolenaar added this to the Next release milestone Aug 14, 2014

@amolenaar amolenaar merged commit 316d988 into unclebob:master Aug 17, 2014

@amolenaar amolenaar deleted the amolenaar:pagedata branch Sep 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment