Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure scenarios invoked from scripts use the ScriptTable class of the calling script #507
Conversation
fhoeben
added some commits
Aug 20, 2014
amolenaar
reviewed
Aug 20, 2014
| ScriptTable scriptTable = new ScriptTable(newTable, id, testContext); | ||
| protected ScriptTable createChild(ScenarioTestContext testContext, SlimTable parentTable, Table newTable) { | ||
| ScriptTable scriptTable; | ||
| if (parentTable instanceof ScriptTable && !parentTable.getClass().equals(ScriptTable.class)) { |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
amolenaar
Aug 20, 2014
Collaborator
Why this differency in table creation? Shouldn't ScriptTable be created the same way as it's customised sub class?
amolenaar
Aug 20, 2014
Collaborator
Why this differency in table creation? Shouldn't ScriptTable be created the same way as it's customised sub class?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fhoeben
Aug 20, 2014
Contributor
When a DecisionTable creates a scenario the parent table is not a script.
When a ScriptTable (not a subclass is used) I avoided reflection, so no reflection was needed at all. Maybe it's premature optimization.
fhoeben
Aug 20, 2014
Contributor
When a DecisionTable creates a scenario the parent table is not a script.
When a ScriptTable (not a subclass is used) I avoided reflection, so no reflection was needed at all. Maybe it's premature optimization.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
fhoeben
Aug 21, 2014
Contributor
Last commit is not really for making the ScenarioTable create custom subclasses, but the change was so small a separate branch seems wasted effort
|
Last commit is not really for making the ScenarioTable create custom subclasses, but the change was so small a separate branch seems wasted effort |
amolenaar
added this to the
Next release milestone
Aug 23, 2014
amolenaar
merged commit 5994fa6
into
unclebob:master
Aug 23, 2014
added a commit
that referenced
this pull request
Aug 23, 2014
fhoeben commentedAug 20, 2014
When a custom subclass of ScriptTable is used and a scenario is invoked from the script. Currently the ScenarioTable class will always convert its contents into assertions using the standard ScriptTable class.
To me it seems more natural/expected that the ScenarioTable would use the table-class of the calling script. This view seems to be supported by the documentation (FitNesse.UserGuide.WritingAcceptanceTests.SliM.ScenarioTable) which states: "They are macros, not programs. They are constructed via text substitution." which to me indicates the type of script table used should not change when replacing lines of script with a scenario call.