Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified command Line parser with support for config files with space in the file/folder name i.e. "c:\program files\file name.config" #508

Merged
merged 5 commits into from Aug 23, 2014

Conversation

@sergebug
Copy link
Contributor

@sergebug sergebug commented Aug 21, 2014

As per discussion in #497 strips out double quotes.

sergebug and others added 5 commits Jul 11, 2014
support properly classpath which starts with quotes but ends without
like: "c:\program files\x\bin\file.dll";fixtures\testFixtures\another.dll
Runtime supports it only via string. Arrays don't work.
@amolenaar amolenaar added this to the Next release milestone Aug 23, 2014
@amolenaar amolenaar merged commit 85c7d73 into unclebob:master Aug 23, 2014
amolenaar added a commit that referenced this issue Aug 23, 2014
Modified command Line parser with support for config files with space in the file/folder name i.e. "c:\program files\file name.config"
@amolenaar
Copy link
Collaborator

@amolenaar amolenaar commented Aug 26, 2014

I think the SLIM_FLAGS property needs to be treated the same way as COMMAND_PATTERN. Am I correct?

@sergebug
Copy link
Contributor Author

@sergebug sergebug commented Aug 26, 2014

I don't know. I never actually used that one and documentation doesn't give me any info except for the fact that it exists. :)

@amolenaar
Copy link
Collaborator

@amolenaar amolenaar commented Aug 27, 2014

Same here actually. You can do everything with the COMMAND_PATTERN as well. Maybe it's about time we deprecate this property :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants