New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance segregation of requirements and implementation #510

Merged
merged 10 commits into from Aug 24, 2014

Conversation

Projects
None yet
2 participants
@six42
Contributor

six42 commented Aug 24, 2014

This change contains one enhancement and three bug fixes.

Enhancement:
Output parameters in a decision table have been previously ignored in scenarios.
Now they are available in the scenario. This allows to better segregate requirements from the implementation. See the test page "SegregationOfRequirementsAndImplementation" for details.

Bug Fixes:

  1. StackTraceEnricherTest fails under Windows if folder contains spaces
    This fixes a problem with this junit test under windows if a folder name
    contains a space. In the identified location the space is replaced with
    "%20" will classpath has spaces. This fixes this problem by replacing
    all "%20" with a space in the location. As the test already replaces /
    and \ one more replacement should not break anything further.
  2. Allow Scenarios with parameterized style but with empty paramter names

This fixes a bug whith parameterized style scenarios where the paramters
have no name like:

|scenario | Division _ _ _ | numerator, denominator, quotient|

Previously this only worked with two spaces between each underscore. The
regex pattern has been fixed to work now with only one space.

  1. SyntaxErrors are now counted in the TestSummary

A table has a syntax error during parsing. E.g. a scenrio without a
name:

|scenario|

Also the table was marked as FAILED the test summary had zero failures.
Three things have been fixed now:
3.1. instead of FAILED the table is shown as ERROR/EXCEPTION
3.2. The test summary shows 1 exception
3.3. The error text which contains HTML is printed correctly (with the
HTML formatting) in the table

six42 added some commits Aug 23, 2014

StackTraceEnricherTest fails under Windows if folder contains spaces
This fixes a problem with this junit test under windows if a folder name
contains a space. In the identified location the space is replaced with
"%20" will classpath has spaces.  This fixes this problem by replacing
all "%20" with a space in the location. As the test already replaces /
and \ one more replacement should not break anything further.
Allow Scenarios with parameterized style but with empty paramter names
This fixes a bug whith parameterized style scenarios where the paramters
have no name like:

|scenario | Division _ _ _ | numerator, denominator, quotient|

Previously this only woked with two spaces between each underscore. The
regex pattern has been fixed to work now with only one space.
SyntaxErrors are now counted in the TestSummary
A table has a syntax error during parsing. I.e. a scenrio without a
name:

|scenario|

Also the table was marked as FAILED the test summary had zero failures.
Three things have been fixed now:
1. instead of FAILED the table is shown as ERROR/EXCEPTION
2. The test summary shows 1 exception
3. The error text which contains HTML is printed correctly (with the
HTML formatting)  in the table
Pass output parameters from a decision table to the implementing scen…
…ario

output parameters in a decision table have been ignored in scenarios.
Now they are available.
AcceptanceTest: Allow Scenarios with parameterized style but with emp…
…ty paramter names

1. Simplified documentation of the variable scope.
2. Acceptance test for the below issue:
This fixes a bug whith parameterized style scenarios where the paramters
have no name like:

|scenario | Division _ _ _ | numerator, denominator, quotient|

Previously this only woked with two spaces between each underscore. The
regex pattern has been fixed to work now with only one space.
TestCase: SyntaxErrors are now counted in the TestSummary
Acceptance Test for the below:
A table has a syntax error during parsing. E.g. a scenrio without a
name:

|scenario|

Also the table was marked as FAILED the test summary had zero failures.
Three things have been fixed now:
1. instead of FAILED the table is shown as ERROR/EXCEPTION
2. The test summary shows 1 exception
3. The error text which contains HTML is printed correctly (with the
HTML formatting)  in the table
Pass output parameters from a decision table to the implementing sce…
…nario

Acceptance Test:
output parameters in a decision table have been ignored in scenarios.
Now they are available.
AcceptanceTest: Allow Scenarios with parameterized style but with em…
…pty parameter names

Fixed a typing error which made the test fail

@amolenaar amolenaar added this to the Next release milestone Aug 24, 2014

@amolenaar

This comment has been minimized.

Show comment
Hide comment
@amolenaar

amolenaar Aug 24, 2014

Collaborator

Wow! Nice work. I especially like the scenarios and decision table fix.

Collaborator

amolenaar commented Aug 24, 2014

Wow! Nice work. I especially like the scenarios and decision table fix.

amolenaar added a commit to amolenaar/fitnesse that referenced this pull request Aug 24, 2014

Merge pull request unclebob#510 from six42/master
Enhance segregation of requirements and implementation

@amolenaar amolenaar merged commit f8c78ac into unclebob:master Aug 24, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment