Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature #529 - Allow Markup Variables In Test & Page Responder Urls #531
referenced this pull request
Oct 6, 2014
Not using SystemVariableSource for URL params has made the WikiPageResponder implementation more complicated because the params now need to be referenced during WikiPage creation in WikiPageUtil and multiple other places. Want to better understand changes before submitting a new pull request - new ETA 10/12 (12-10).
Nice work. From the code I see that rendering a normal wiki page with those extra parameters is pretty complicated :(. I expected (/hoped) it would be easier. I added one remark about the ParsingPage, to avoid the request parameters to leak into the wikitext package. Then I think it's okay for merge.
I have some second thoughts on the
added a commit
this pull request
Oct 26, 2014
I removed the change from ParsingPage. UrlPathVariableSource already does a parameter lookup, so that should suffice. We'll have to see what to do about BaseWikiPage.setUrlParams(). I don't like the fact we "set" stuff on the page, but the way VariableSource is handled by the wiki pages leaves us no alternative.