New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break cycles created by Symlinks. #888

Merged
merged 1 commit into from Mar 19, 2016

Conversation

Projects
None yet
1 participant
@amolenaar
Collaborator

amolenaar commented Mar 15, 2016

Previously, the PageCrawler refused to traverse symlinks. This caused some odd behaviour (see #488).

I changed the logic in a sense that there is some cycle detection and the user is informed if pages a (sym)linked in such a way that a cycle (infinite loop) of pages exists.

Fixes #488

Break cycles created by Symlinks.
Move this logic to symlinks, and not in the page crawler. This implies that things like searches work over symlinks as well.

Fixes #488.

@amolenaar amolenaar added this to the Next release milestone Mar 15, 2016

@amolenaar amolenaar merged commit aa1467d into unclebob:master Mar 19, 2016

amolenaar added a commit that referenced this pull request Mar 19, 2016

Merge pull request #888 from amolenaar/symlink-cycles
Break cycles created by Symlinks.

@amolenaar amolenaar deleted the amolenaar:symlink-cycles branch Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment